filenameCollisionCheck defaults to false

[brunobowden]

Defaults to True when translateArgs contains “—no-package-directories”

Fixes #467

[brunobowden]

@advayDev1 - PTAL

[advayDev1]

would be clearer to call this 'forceFilenameCollisionCheck' and then change the javadoc.
it is not the case that this variable should be set to true, in fact we are just treating it as if it was true when no-package-directories is present.

[advayDev1]

lgtm with comments

[brunobowden]

So Clang allows compiles with the directory structure from the command line but not through Xcode?

Just waiting for CI to complete and then I'll merge.

[brunobowden]

Merging...
The Xcode build now takes 18 minutes which is a long time.

[advayDev1]

Xcode actually passes every individual file to clang separately. So I think it is xcode's 'choice' not to support directories. Also what is taking 18 minutes? Which task?

[brunobowden]

The recent Xcode builds take 18-20 minutes:
https://travis-ci.org/j2objc-contrib/j2objc-gradle/jobs/82959080

Adding the Guava was responsible, you can see that from the build history:
https://travis-ci.org/j2objc-contrib/j2objc-gradle/builds

[advayDev1]

OH: the continuous integration builds are 18 minutes. Not like your dev Xcode builds for your project.

Yeah, that is true. But I don't see how we can really exercise the plugin unless it is building multiple projects with dependencies - Guava's our best bet for our various features really.

[advayDev1]

This is the first time I'm actually comfortable that changes aren't breaking the plugin. Unit-tests can only do so much with the amount of inter-tool interaction we have

[brunobowden]

The level of complexity in the system is considerable. It's a lot more
complex that your typical library.

On Wed, Sep 30, 2015 at 9:51 AM Advay Mengle [email protected]
wrote:

This is the first time I'm actually comfortable that changes aren't
breaking the plugin. Unit-tests can only do so much with the amount of
inter-tool interaction we have

—
Reply to this email directly or view it on GitHub
#470 (comment)
.

[advayDev1]

Is 'it' our plugin? Or guava as the system-under-test?

Either way I think that's the whole benefit of Travis. We don't need to serially spend time (or our local CPU cycles) waiting those 18 minutes. You push and do other work in parallel. Like with any presubmit, devs usually have enough pipelined work that a remote system thoroughly testing shouldn't delay work.

Also Travis has a feature such that for example if you are strictly changing only CONTRIBUTING or README, etc. add '[skip ci] anywhere in the commit, and Travis will auto-green the CL.