Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filenameCollisionCheck should default to the value of no-package-directories #467

Closed
advayDev1 opened this issue Sep 28, 2015 · 0 comments
Closed

filenameCollisionCheck should default to the value of no-package-directories #467

advayDev1 opened this issue Sep 28, 2015 · 0 comments
Labels
cat:translation type:bug
Milestone
0.5 Release

Comments

@advayDev1
Copy link
Contributor

Currently filenameCollisionCheck defaults to true, even though no-package-directories defaults to false. This is incorrect. Only if no-package-directories is set should filenameCollisionCheck be true (by default).
@advayDev1 advayDev1 mentioned this issue Sep 28, 2015
Merged
@brunobowden brunobowden self-assigned this Sep 28, 2015
@brunobowden brunobowden added this to the 0.5 Release milestone Sep 28, 2015
@advayDev1 advayDev1 mentioned this issue Sep 28, 2015
Merged
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Sep 29, 2015
@brunobowden
filenameCollisionCheck default to false
0401870 
Defaults to True when translateArgs contains “—no-package-directories”

Fixes j2objc-contrib#467
@brunobowden brunobowden mentioned this issue Sep 29, 2015
Merged
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Sep 30, 2015
@brunobowden
filenameCollisionCheck default to false
61bc332 
Defaults to True when translateArgs contains “—no-package-directories”

Fixes j2objc-contrib#467
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Sep 30, 2015
@brunobowden
filenameCollisionCheck default to false
0322767 
Defaults to True when translateArgs contains “—no-package-directories”

Fixes j2objc-contrib#467
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Sep 30, 2015
@brunobowden
filenameCollisionCheck default to false
0ffe6f6 
Defaults to True when translateArgs contains “—no-package-directories”

Fixes j2objc-contrib#467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:translation type:bug
Projects
None yet
Milestone
0.5 Release
Development

No branches or pull requests
2 participants
@brunobowden @advayDev1