Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcodeTarget to also automatically match Tests and WatchKit App #353

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

brunobowden
Copy link
Contributor

For an iOS app target of ‘IOS-APP’, this will add linkages for other
iOS targets that start with the same name. Such as ‘IOS-APPTests’,
‘IOS-APP WatchKit App’ and ‘IOS-APP WatchKit Extension’.

  • Automatic linkage for Apple Watch apps and extension
  • Matches against all targets that start with the same prefix
  • Standardize xcodeTarget examples and test to use ‘IOS-APP’

@brunobowden
Copy link
Contributor Author

@advayDev1, @confile - PTAL, something I needed to make development easier for WatchKit Apps

@confile
Copy link
Contributor

confile commented Aug 17, 2015

What does this pull request?

static void appendArgs(String[] arrayArgs, String nameArgs, String... args) {
verifyNoSpaceArgs(nameArgs, args)
for (String arg in args) {
arrayArgs += arg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work? you can modify the arrayArgs reference passed in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I was wondering the same thing and decided I need to unit test it... having now added the test, it doesn't work. So I've reverted the changes for String[] variables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah for other collections this is an .addAll call, and for arrays it is really an assignment and a plus. one of the annoyances of groovy magic

For an iOS app target of ‘IOS-APP’, this will add linkages for other
iOS targets that start with the same name. Such as ‘IOS-APPTests’,
‘IOS-APP WatchKit App’ and ‘IOS-APP WatchKit Extension’.

- Automatic linkage for Apple Watch apps and extension
- Matches against all targets that start with the same prefix
- Standardize xcodeTarget examples and test to use ‘IOS-APP’
@brunobowden
Copy link
Contributor Author

@advayDev1 - it's all fixed up now

@confile - this makes it easier to work with multiple targets. For example, having a WatchKit app as well.

@advayDev1
Copy link
Contributor

LGTM

brunobowden added a commit that referenced this pull request Aug 17, 2015
xcodeTarget to also automatically match Tests and WatchKit App
@brunobowden brunobowden merged commit 0c621b7 into j2objc-contrib:master Aug 17, 2015
@confile
Copy link
Contributor

confile commented Aug 17, 2015

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants