Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert xcodeTarget to enumerated list #441

Closed
brunobowden opened this issue Aug 30, 2015 · 1 comment
Closed

convert xcodeTarget to enumerated list #441

brunobowden opened this issue Aug 30, 2015 · 1 comment
Assignees
@brunobowden
Milestone
0.5 Release

Comments

@brunobowden
Copy link
Contributor

PR #353 matches multiple Xcode targets based on substring matching. Proper support means enumerating the list of targets instead. Given that it's now multiple targets, it also means that the name changes: xcodeTarget => xcodeTargets. With a breaking change like this, I think it would be wise to provide error message for the old syntax explaining how to fix it. Then remove that old syntax (and error) on a future release.

Before:

xcodeTarget 'IOS-APP'

After

xcodeTargets 'IOS-APP', 'WatchKit App', 'WatchKit Extension'
@brunobowden brunobowden self-assigned this Aug 30, 2015
@brunobowden brunobowden added this to the 0.5 Release milestone Aug 30, 2015
@confile
Copy link
Contributor

confile commented Aug 30, 2015

+1

brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Oct 3, 2015
@brunobowden
xcodeTargets as enumerated list
2c82346 
Now defaults to all targets when none are specified
Corresponding unit tests updated

Fixes j2objc-contrib#441
@brunobowden brunobowden mentioned this issue Oct 3, 2015
Merged
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Oct 3, 2015
@brunobowden
xcodeTargets as enumerated list
7111f49 
Now defaults to all targets when none are specified
Corresponding unit tests updated

Fixes j2objc-contrib#441
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Oct 3, 2015
@brunobowden
xcodeTargets as enumerated list
0389fc2 
Now defaults to all targets when none are specified
Corresponding unit tests updated

Fixes j2objc-contrib#441
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Oct 4, 2015
@brunobowden
xcodeTargets as enumerated list
71f7654 
Now defaults to all targets when none are specified
Corresponding unit tests updated

Fixes j2objc-contrib#441
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Oct 5, 2015
@brunobowden
xcodeTargets as enumerated list
3e49cc7 
Now defaults to all targets when none are specified
Corresponding unit tests updated

Fixes j2objc-contrib#441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobowden brunobowden

Labels
None yet
Projects
None yet
Milestone
0.5 Release
Development

No branches or pull requests
2 participants
@confile @brunobowden