Skip to content

Commit

Permalink
Merge branch 'develop-ci-jsonpath' into develop. Close nasa#151.
Browse files Browse the repository at this point in the history
**Description**

`jsonpath` uses a function that is only available in `aeson >= 2.0.3.0`,
but the dependency only requires `aeson >= 2`. This breaks the
installation in the CI jobs if `aeson >= 2 && aeson < 2.0.3.0` is
picked.

**Type**

- Management: fix to CI set up due to issue with dependency.

**Additional context**

None.

**Requester**

- Ivan Perez.

**Method to check presence of bug**

Not applicable (not a bug).

**Expected result**

- Installation in the CI jobs completes successfully.

**Desired result**

- Installation in the CI jobs completes successfully.

**Proposed solution**

- Add a constraint in the CI jobs to require `aeson` greater than `2.0.2.0`.

**Further notes**

- The issue is with a dependency, so it's not really a bug in our
  project. This is therefore classified as management.

- The issue has been filed with `jsonpath` at:
  akshaymankar/jsonpath-hs#48
  • Loading branch information
ivanperez-keera committed Sep 22, 2024
2 parents eb2a995 + b490ab0 commit 62a45e8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/repo-ghc-8.6-cabal-2.4-ros.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Install ogma
run: |
cabal v1-install copilot ogma-**/ --constraint="copilot >= 3.19.1"
cabal v1-install copilot ogma-**/ --constraint="copilot >= 3.19.1" --constraint="aeson >= 2.0.3.0"
- name: Generate ROS app
run: |
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/repo-ghc-8.6-cabal-2.4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,10 @@ jobs:
# the dependencies do not change and cabal does not change the
# installation plan (which would mean we'd be running the tests with a
# version of ogma compiled with different dependencies).
cabal v1-install ogma-**/ --enable-tests
cabal v1-install ogma-**/ --enable-tests --constraint="aeson >= 2.0.3.0"
- name: Test all packages
run: |
# We want to document the build process, and get detailed information
# if there is a problem (or if all goes well). We therefore execute the
# installation with -j1.
cabal v1-install ogma-**/ --enable-tests --run-tests -j1
cabal v1-install ogma-**/ --enable-tests --run-tests -j1 --constraint="aeson >= 2.0.3.0"
4 changes: 4 additions & 0 deletions ogma-cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Revision history for ogma-cli

## [1.4.X] - 2024-09-21

* Constrain version of dependency in CI jobs (#151).

## [1.4.0] - 2024-05-21

* Version bump 1.4.0 (#145).
Expand Down

0 comments on commit 62a45e8

Please sign in to comment.