Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogma-cli: Problem with dependency prevents CI jobs from completing #151

Closed
ivanperez-keera opened this issue Sep 22, 2024 · 6 comments
Closed
Assignees
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Management Admin only: Change request for conformance with policies or procedures
Milestone

Comments

@ivanperez-keera
Copy link
Member

ivanperez-keera commented Sep 22, 2024

Description

jsonpath uses a function that is only available in aeson >= 2.0.3.0, but the dependency only requires aeson >= 2. This breaks the installation in the CI jobs if aeson >= 2 && aeson < 2.0.3.0 is picked.

Type

  • Management: fix to CI set up due to issue with dependency.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

Not applicable (not a bug).

Expected result

  • Installation in the CI jobs completes successfully.

Desired result

  • Installation in the CI jobs completes successfully.

Proposed solution

  • Add a constraint in the CI jobs to require aeson greater than 2.0.2.0.

Further notes

@ivanperez-keera ivanperez-keera added CR:Status:Initiated Admin only: Change request that has been initiated CR:Type:Management Admin only: Change request for conformance with policies or procedures labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Confirmed that the issue exists.

@ivanperez-keera ivanperez-keera added CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager and removed CR:Status:Initiated Admin only: Change request that has been initiated labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera ivanperez-keera added CR:Status:Accepted Admin only: Change request accepted by technical lead and removed CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

ivanperez-keera commented Sep 22, 2024

Technical Lead: Issue scheduled for fixing in Ogma 1.4.1.
Fix assigned to: @ivanperez-keera.

@ivanperez-keera ivanperez-keera added CR:Status:Scheduled Admin only: Change requested scheduled and removed CR:Status:Accepted Admin only: Change request accepted by technical lead labels Sep 22, 2024
@ivanperez-keera ivanperez-keera added this to the 1.5.0 milestone Sep 22, 2024
@ivanperez-keera ivanperez-keera self-assigned this Sep 22, 2024
ivanperez-keera added a commit that referenced this issue Sep 22, 2024
jsonpath uses a function that is only available in aeson >= 2.0.3.0, but
the dependency only requires aeson >= 2. This breaks the installation in
the CI jobs if aeson >= 2 && aeson < 2.0.3.0 is picked.

This commit modifies the CI jobs adding a constraint in the installation
of ogma to require aeson greater than 2.0.2.0.
@ivanperez-keera ivanperez-keera added CR:Status:Implementation Admin only: Change request that is currently being implemented and removed CR:Status:Scheduled Admin only: Change requested scheduled labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Implementor: Solution implemented, review requested.

@ivanperez-keera ivanperez-keera added CR:Status:Verification Admin only: Change request that is currently being verified and removed CR:Status:Implementation Admin only: Change request that is currently being implemented labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

@ivanperez-keera
Copy link
Member Author

Change Manager: Implementation ready to be merged.

@ivanperez-keera ivanperez-keera added CR:Status:Closed Admin only: Change request that has been completed and removed CR:Status:Verification Admin only: Change request that is currently being verified labels Sep 22, 2024
@ivanperez-keera ivanperez-keera changed the title ogma: Problem with dependency prevents CI jobs from completing ogma-cli: Problem with dependency prevents CI jobs from completing Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Management Admin only: Change request for conformance with policies or procedures
Projects
None yet
Development

No branches or pull requests

1 participant