Skip to content

fix(sabnzbd): treat :: as unset in the vendored run script #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-pinatti merged 3 commits into from
Sep 27, 2026
Merged

fix(sabnzbd): treat :: as unset in the vendored run script #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2944fe8
fix(devcontainer): allow the ubuntu egress set for the L2 image build
ivan-pinatti Sep 27, 2026
ae2c532
fix(sabnzbd): treat :: as unset in the vendored run script
ivan-pinatti Sep 27, 2026
3947bcd
revert: drop the redundant ubuntu egress set
ivan-pinatti Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion patches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ under those terms. See [NOTICE.md](../NOTICE.md).
| Directory | Upstream project | Upstream license | Contents |
| --- | --- | --- | --- |
| `mylar/` | [MylarComics/mylar3](https://github.com/mylarcomics/mylar3) | GPL-3.0-or-later | Five complete source files, modified to add qBittorrent HTTPS support (self-signed certificate handling in the torrent client and its config UI) |
| `sabnzbd/` | [linuxserver/docker-sabnzbd](https://github.com/linuxserver/docker-sabnzbd) | GPL-3.0 | `svc-sabnzbd/run`, the image's own s6 service script, changed to pass `--server` only when the configured host is missing or loopback. Upstream passes it unconditionally, and it overrides `host` in `sabnzbd.ini` and is persisted back into it, so `host = 0.0.0.0` cannot survive a start |
| `sabnzbd/` | [linuxserver/docker-sabnzbd](https://github.com/linuxserver/docker-sabnzbd) | GPL-3.0 | `svc-sabnzbd/run`, the image's own s6 service script, changed to pass `--server` only when the configured host is missing, loopback or `::` (the image's own default). Upstream passes it unconditionally, and it overrides `host` in `sabnzbd.ini` and is persisted back into it, so `host = 0.0.0.0` cannot survive a start |

`mylar/mylar/config.py` and `mylar/mylar/webserve.py` carry their original GPL
headers. Do not strip them. Because these are complete GPL-3.0 files rather
Expand Down
9 changes: 7 additions & 2 deletions patches/sabnzbd/svc-sabnzbd/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ FAMILY=::
# That keeps the protection upstream cares about: nobody can bind 127.0.0.1 and
# lock themselves out of the web UI.
#
# :: is treated as unset too. It is upstream's own default and SABnzbd persists
# --server into the ini, so almost every existing config holds it. Respecting it
# would bypass the fallback to 0.0.0.0 below on a machine without IPv6, and
# SABnzbd would fail to bind.
#
# Section tracking rather than a plain grep for `^host`, because the NNTP server
# entries under [servers] carry their own unindented `host = ...` line. Matching
# the wrong one would hand a news server's hostname to --server.
Expand All @@ -32,7 +37,7 @@ if [[ -z ${LSIO_NON_ROOT_USER} ]]; then
# would let that fallback clobber a configured host on a machine without
# IPv6, which is the bug this exists to fix.
case ${CONFIGURED_HOST} in
"" | 127.0.0.1 | ::1 | localhost) ;;
"" | :: | 127.0.0.1 | ::1 | localhost) ;;
*) FAMILY=${CONFIGURED_HOST} ;;
esac

Expand All @@ -42,7 +47,7 @@ if [[ -z ${LSIO_NON_ROOT_USER} ]]; then
--config-file /config --server "$FAMILY"
else
case ${CONFIGURED_HOST} in
"" | 127.0.0.1 | ::1 | localhost) ;;
"" | :: | 127.0.0.1 | ::1 | localhost) ;;
*) FAMILY=${CONFIGURED_HOST} ;;
esac

Expand Down
Loading