Repository navigation
fix(sabnzbd): treat :: as unset in the vendored run script - #231
Conversation
.devcontainer/l2/Dockerfile installs shfmt with apt, but egress-sets did not list ubuntu, so the proxy refused archive.ubuntu.com and security.ubuntu.com with a 403 and the L2 image could not be built in a fresh engine. Every commit from the workbench failed at the pre-commit hook as a result.
SABnzbd persists --server into sabnzbd.ini, so almost every existing config holds host = ::, the image's own default. The patch respected it as a configured host, which bypassed the fallback to 0.0.0.0 on a machine without IPv6, where SABnzbd would then fail to bind. :: now takes the same path as an unset or loopback host. A deliberate host = 0.0.0.0, which this stack sets, is still respected. Mirrors the same fix pushed to linuxserver/docker-sabnzbd#275, so the code stays identical to the upstream proposal.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ivan-pinatti-labs/docker-torrent-box-with-vpn/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe always-on egress sets now include Ubuntu. A comment identifies Ubuntu’s archive as the source used to install ChangesUbuntu Egress Access
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable issue is established for the Ubuntu egress addition; it is mergeable after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/run-tests |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The workbench already adds ubuntu and nodesource to the proxy for any checkout with a .devcontainer/l2/Dockerfile, so listing it here changes nothing. The 403 that prompted it came from starting the workbench against a main clone old enough to predate the L2 Dockerfile, while the commit ran in a current worktree. Not a defect in this repository. This reverts commit 2944fe8.
|
/run-tests |
What
patches/sabnzbd/svc-sabnzbd/runnow treats::as unset. SABnzbd persists--serverintosabnzbd.ini, so almost every existing config holdshost = ::, the image's own default. The patch respected that as a configured host, which bypassed the image's fallback to0.0.0.0on a machine without IPv6, where SABnzbd would then fail to bind.::now takes the same path as an unset or loopback host. A deliberatehost = 0.0.0.0, which this stack sets, is still respected.The branch also carries a
.devcontainer/egress-setschange and its revert, so the net diff is the patch alone. The workbench already addsubuntufor any checkout with an L2 Dockerfile; the 403 that prompted the change came from starting the workbench against an outdated main clone.Why
The same
::fix was pushed to the upstream proposal, linuxserver/docker-sabnzbd#275, and this patch is meant to stay identical to it so it can be deleted once upstream ships. Tracked in #108.Testing
hostunset, empty,::,0.0.0.0,127.0.0.1,::1and a LAN style address. The only change from the previous patch is::without IPv6, which now resolves to0.0.0.0, matching the unpatched image.lscr.io/linuxserver/sabnzbd:5.1.3-ls274with the script bind mounted: fresh config,0.0.0.0,::and127.0.0.1all start, serve the web UI, and keep the expectedhostacross a restart.