Fix to internal changes in HTTP::Client#4599
Closed
beta-ziliani wants to merge 1 commit intoiv-org:masterfrom
Closed
Fix to internal changes in HTTP::Client#4599beta-ziliani wants to merge 1 commit intoiv-org:masterfrom
beta-ziliani wants to merge 1 commit intoiv-org:masterfrom
Conversation
Member
|
Thanks for the pull request! However the fix is more or less unnecessary since the whole proxy code there is set to get removed in the next batch of PRs merged. See #4570 |
Member
|
Closing, as I'm going to merge #4570. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crystal 1.12 changed the way timeouts are stored in
HTTP::Client. Accessing the fields directly is a bad idea, but the interface doesn't provide getters.Ref: crystal-lang/crystal#14371
EDIT: This is PR to fix the problem in CI, but with no consideration to possible better alternatives.