Refactor HTTP::Client timeout ivars to Time::Span#14371
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 20, 2024
Merged
Conversation
This is primarily an internal refactor which leaves the public API untouched. Only change is that the new setter methods also allow `Nil` values to unset the timeout again.
ysbaddaden
approved these changes
Mar 19, 2024
Collaborator
ysbaddaden
left a comment
ysbaddaden
left a comment
There was a problem hiding this comment.
The one change is the type of the instance variables, which are private, and luckily we never exposed the getters 👍
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily an internal refactor which leaves the public API untouched. Only change is that the new setter methods also allow
Nilvalues to unset the timeout again.Resolves part of #14368