Add ability to disable all user notifications#3473
Merged
unixfox merged 1 commit intoiv-org:masterfrom Jan 5, 2023
Merged
Conversation
unixfox
requested review from
a team,
SamantazFox and
TheFrenchGhosty
as code owners
unixfox
force-pushed
the
disable-notifications-hard
branch
from
ffdcfd2 to
cbb4806
Compare
FireMasterK
reviewed
Dec 7, 2022
SamantazFox
approved these changes
Jan 5, 2023
Member
SamantazFox
left a comment
SamantazFox
left a comment
There was a problem hiding this comment.
Looks good to me. I've only proposed some rewording of the config option comment.
unixfox
force-pushed
the
disable-notifications-hard
branch
from
cbb4806 to
5b8ca37
Compare
11 tasks
stavros-k
pushed a commit
to trueforge-org/truecharts
that referenced
this pull request
Oct 1, 2023
Add enable_user_notifications config option to Invidious This will allow you to toggle `enable_user_notifications` on or off (default on) via iv-org/invidious#3473 ⚒️ Fixes #13125 - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ]⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** Installed the helm chart locally with no errors **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [x]⚠️ My changes generate no new warnings - [x] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to disable all the user notifications in order to combat against the ever-growing disk space generated by refreshing the user notifications.
See #2042 (comment) for more info.
About the PR I have not disabled everything when the parameter is set to false, mainly in the file https://github.com/iv-org/invidious/blob/master/src/invidious/users.cr#L133 because I fear to break something. Feel free to improve my code about that if needed.
But the basic idea is implemented, no notification items are created when the setting
enable_user_notificationsis turned off and on the UI side the user won't see any notifications anymore.A new method
feed_needs_updatein database/users.cr has been created in order to ask for Invidious to refresh the user feed without creating a new notification item.