Add ability to disable notifications

[unixfox]

This PR adds the ability to disable notifications.

---

In error:

Showing last frame. Use --error-trace for full trace.

In src/invidious/channels/channels.cr:229:8

 229 | if preferences.notifications && was_insert
          ^----------
Error: undefined local variable or method 'preferences' for top-level

[SamantazFox]

Note that you can't check the preferences in here: this function is called by the refresh job and hence lacks any user context. We need to add a column to the postgres table users so we can do the following:

UPDATE ... 
SET array_append(subscriptions, '<video_id>')
WHERE notifications = true AND '<ucid>' = ANY(subscriptions)

[unixfox]

We can't do that until we have #2878 merged then?

[unixfox]

Mmh the query you are talking about, is it this one: https://github.com/iv-org/invidious/blob/master/src/invidious/database/users.cr#L100?

We could just temporarily convert the preferences column to a json object then check in a where clause which user has notifications enabled.

[SamantazFox]

Yep, it's better to wait for 2878 to be merged, so we can start some work on the DB.
And no, the function that updates notifications is this one:

invidious/src/invidious/database/users.cr

Lines 122 to 131 in 081fd54

	def add_notification(video : ChannelVideo)
	request = <<-SQL
	UPDATE users
	SET notifications = array_append(notifications, $1),
	feed_needs_update = true
	WHERE $2 = ANY(subscriptions)
	SQL
	PG_DB.exec(request, video.id, video.ucid)
	end

. the one you gave is the function used when a user subscribes to a channel.

As for the temporary solution, Imo it would be preferrable to not clutter the code now.

[SamantazFox]

@unixfox do you mind if I close this PR?

[unixfox]

@unixfox do you mind if I close this PR?

I don't know why you really want to close this PR but if you think you have to do it then you can close it.

[SamantazFox]

Related: #1998 #1999

[github-actions]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[github-actions]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[github-actions]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[github-actions]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[SamantazFox]

I guess this can be closed, now that #3473 has been merged?

[unixfox]

I guess this can be closed, now that #3473 has been merged?

No it's per user here, no globally.

[github-actions]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.