Deploy example on heroku #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
approved these changes
Jul 5, 2022
|
I've actually implemented some of those changes in #33, but they depend on tailwind so they can't be merged back here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration for the example website to be deployed onto Heroku. I used Heroku's official NGINX buildpack because heroku-buildpack-static is deprecated, but there isn't really a need for a custom server yet.
It also slightly improves the landing page, but only by a little.
We may have to re-add
heroku-buildpack-nginxto some instances of this repo's apps, possibly including production, so I'll check after this is merged.