Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue132, issue135, and issue136 - Move to TestLab, add tests for sample, and refactors #137

Merged
merged 40 commits into from
Jun 23, 2019

Conversation

isuPatches
Copy link
Owner

close #132
close #135
close #136

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #137 into 4.x will decrease coverage by 2.32%.
The diff coverage is 93.02%.

Impacted file tree graph

@@             Coverage Diff             @@
##                4.x    #137      +/-   ##
===========================================
- Coverage     96.52%   94.2%   -2.33%     
- Complexity      288     682     +394     
===========================================
  Files            15      53      +38     
  Lines           749    1501     +752     
  Branches        194     253      +59     
===========================================
+ Hits            723    1414     +691     
- Misses            7      41      +34     
- Partials         19      46      +27
Impacted Files Coverage Δ Complexity Δ
...om/isupatches/wisefysample/ui/main/MainFragment.kt 100% <ø> (ø) 3 <0> (?)
...upatches/wisefysample/ui/search/SearchPresenter.kt 100% <ø> (ø) 19 <0> (?)
...supatches/wisefysample/ui/search/SearchFragment.kt 92.1% <ø> (ø) 101 <0> (?)
...patches/wisefysample/internal/base/BaseActivity.kt 0% <ø> (ø) 0 <0> (?)
...isupatches/wisefysample/internal/nav/MainRouter.kt 62.5% <ø> (ø) 0 <0> (?)
.../isupatches/wisefysample/internal/util/HtmlUtil.kt 33.33% <ø> (ø) 0 <0> (?)
...tches/wisefysample/ui/remove/RemoveNetworkModel.kt 100% <ø> (ø) 2 <0> (?)
...atches/wisefysample/internal/models/NetworkType.kt 100% <ø> (ø) 2 <0> (?)
...patches/wisefysample/internal/util/KeyboardUtil.kt 66.66% <ø> (ø) 0 <0> (?)
...es/wisefysample/ui/remove/RemoveNetworkFragment.kt 91.17% <ø> (ø) 20 <0> (?)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c589d...153d979. Read the comment docs.

@isuPatches isuPatches merged commit cf7f0f5 into 4.x Jun 23, 2019
@isuPatches isuPatches deleted the issue132-add-tests-for-sample-app branch June 23, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant