Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/rename getSavedNetwork and getSavedNeworks to indicate search #135

Closed
isuPatches opened this issue May 23, 2019 · 0 comments · Fixed by #137
Closed

Refactor/rename getSavedNetwork and getSavedNeworks to indicate search #135

isuPatches opened this issue May 23, 2019 · 0 comments · Fixed by #137
Assignees
Labels
Status - Released Work that has been released TODO Work that needs a-doin'
Milestone

Comments

@isuPatches
Copy link
Owner

Rename:

  • getSavedNetwork(regex: String)
  • getSavedNetwork(regex: String, callbacks: GetSavedNetworkCallbacks)
  • getSavedNetworks(regex: String)
  • getSavedNetworks(regex: String, callbacks: GetSavedNetworksCallbacks)

to:

  • searchForSavedNetwork(regex: String)
  • searchForSavedNetwork(regex: String, callbacks: SearchForSavedNetworkCallbacks)
  • searchForSavedNetworks(regex: String)
  • searchForSavedNetworks(regex: String, callbacks: SearchForSavedNetworksCallbacks)

This will require breaking up getSavedNetwork and some precheck logic.

@isuPatches isuPatches added the 4.x label May 23, 2019
@isuPatches isuPatches self-assigned this May 23, 2019
@isuPatches isuPatches added this to the 4.x milestone May 23, 2019
@isuPatches isuPatches added Status - Completed A feature that has been developed but not released TODO Work that needs a-doin' labels May 23, 2019
@isuPatches isuPatches added Status - Released Work that has been released and removed Status - Completed A feature that has been developed but not released labels Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status - Released Work that has been released TODO Work that needs a-doin'
Projects
None yet
1 participant