Experimental Support for ambient on Windows#1461
Conversation
|
Skipping CI for Draft Pull Request. |
|
😊 Welcome @keithmattix! This is either your first contribution to the Istio ztunnel repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
proto/zds.proto
Outdated
| string uid = 1; | ||
| WorkloadInfo workload_info = 2; | ||
| // The namespace for the workload. Windows only. | ||
| WindowsNamespace windows_namespace = 3; |
There was a problem hiding this comment.
Why not make this an optional in WorkloadInfo?
There was a problem hiding this comment.
Honestly I think it was in an earlier draft of this, but I can't remember why the shift. Agreed that an optional is much cleaner
There was a problem hiding this comment.
Ah, I remember now, it was because I wanted to model it like the auxiliary data (i.e. the FD) from the unix domain socket communication. I don't really have any preference, and went ahead and just stuck it on workload_info
howardjohn
left a comment
There was a problem hiding this comment.
What happened to a "small 60 line change" 😛
Good stuff. Will take a look soon
| } | ||
|
|
||
| match output { | ||
| Ok(output) => { |
There was a problem hiding this comment.
Minor issue here where it doesn't print anything when powershell fails to execute the script (eg. because of permission policies).
Ok(output) => {
if output.status.success() {
for line in String::from_utf8(output.stdout).unwrap().lines() {
// Each line looks like `istio.io/pkg/version.buildGitRevision=abc`
if let Some((key, value)) = line.split_once('=') {
let key = key.split('.').last().unwrap();
println!("cargo:rustc-env=ZTUNNEL_BUILD_{key}={value}");
} else {
println!("cargo:warning=invalid build output {line}");
}
}
} else {
println!(
"cargo:warning=build info script failed (stderr): {}",
String::from_utf8(output.stderr)
.unwrap()
.replace("\r\n", "")
);
}
}
3d2938e to
e60f7a0
Compare
|
not stale |
|
Not stale |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
a57b20f to
53c1a2c
Compare
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Gustavo Meira <grnmeira@users.noreply.github.com>
|
@howardjohn @craigbox @therealmitchconnors can we get the Ztunnel experimental branch in as well? Thank you! |
|
Doesn't look like it needs a docs maintainer. |
ilrudie
left a comment
There was a problem hiding this comment.
didn't get time to dive in but approving onto the experimental branch
604d90d
into
istio:experimental-windows-ambient
Part of istio/istio#27893. Istio CNI piece is at istio/istio#55216
More information to follow in an upcoming IstioDay talk as well as a blog post, but in summary: we've made substantial progress towards support Istio on Windows, and we decided the time is right to share where we are with the community! After discussing with the rest of Istio TOC, we have agreed that a long-lived experimental branch is the best place for this code to live for now as we work towards productionizing it and getting CI set up.
What works
What doesn't work
I'm opening this PR as a draft for folks to take a look and comment on the diff/approach before merging it into the experimental branch. Feel free to reach out with any questions or concerns. Welcome to Istio, Windows!