Experimental Support for ambient on Windows#55216
Merged
istio-testing merged 19 commits intoistio:experimental-windows-ambientfrom Jun 3, 2025
Merged
Experimental Support for ambient on Windows#55216istio-testing merged 19 commits intoistio:experimental-windows-ambientfrom
istio-testing merged 19 commits intoistio:experimental-windows-ambientfrom
Conversation
Collaborator
|
Skipping CI for Draft Pull Request. |
This was referenced Feb 21, 2025
2a4d3dc to
94877ef
Compare
b372025 to
4ae3235
Compare
Split out linux specific stuff to their own files behind compilation flags. Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
The goal here is that calls to Iptables and WFP look ~the same. Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
1d4c298 to
41c95ed
Compare
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
a606658 to
65afdd5
Compare
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Contributor
Author
|
@therealmitchconnors removed one of the files and explained the rest. As for tests @grnmeira is going to iterate on them before we move this into the master branch |
Contributor
Author
|
/test integ-pilot-istiodremote |
Contributor
|
@therealmitchconnors @howardjohn is there anything else we need here to get this branch merged? As @keithmattix mentioned I intend to start working on the tests once we have this in. |
howardjohn
approved these changes
Jun 2, 2025
Member
howardjohn
left a comment
There was a problem hiding this comment.
did not review, approving since its on experimental branch
therealmitchconnors
approved these changes
Jun 2, 2025
craigbox
approved these changes
Jun 3, 2025
a5c2e9d
into
istio:experimental-windows-ambient
29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #27893. Ztunnel companion PR is istio/ztunnel#1461
More information to follow in an upcoming IstioDay talk as well as a blog post, but in summary: we've made substantial progress towards support Istio on Windows, and we decided the time is right to share where we are with the community! After discussing with the rest of Istio TOC, we have agreed that a long-lived experimental branch is the best place for this code to live for now as we work towards productionizing it and getting CI set up.
What works:
What doesn't work:
Rough edges
I'm opening this PR as a draft for folks to take a look and comment on the diff/approach before merging it into the experimental branch. Feel free to reach out with any questions or concerns. Welcome to Istio, Windows!