Skip to content

build: install python3.8 in proxy build image#1565

Merged
istio-testing merged 3 commits intoistio:masterfrom
lambdai:py3.8forproxy
Jun 7, 2021
Merged

build: install python3.8 in proxy build image#1565
istio-testing merged 3 commits intoistio:masterfrom
lambdai:py3.8forproxy

Conversation

@lambdai
Copy link
Copy Markdown
Contributor

@lambdai lambdai commented Jun 6, 2021

Python 3.8+ is required to build proxy envoy.

The latest python3 in the base proxy build image ubuntu:xenial is python3.5 so we need to build python3.8 from source code.

Fix istio/test-infra#3366
Signed-off-by: Yuchen Dai lambdai@google.com

Signed-off-by: Yuchen Dai <lambdai@google.com>
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 6, 2021
@istio-policy-bot
Copy link
Copy Markdown

😊 Welcome @lambdai! This is either your first contribution to the Istio tools repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 6, 2021
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2021
@lambdai lambdai marked this pull request as ready for review June 6, 2021 18:20
@lambdai lambdai requested a review from a team as a code owner June 6, 2021 18:20
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 6, 2021
Signed-off-by: Yuchen Dai <lambdai@google.com>
Signed-off-by: Yuchen Dai <lambdai@google.com>
@istio-testing istio-testing merged commit 67d13d2 into istio:master Jun 7, 2021
@lambdai lambdai deleted the py3.8forproxy branch June 7, 2021 22:38
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
* build: install python3.8 in proxy build image

Signed-off-by: Yuchen Dai <lambdai@google.com>

* lint

Signed-off-by: Yuchen Dai <lambdai@google.com>

* remove duplicate ln -s python3

Signed-off-by: Yuchen Dai <lambdai@google.com>
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jul 6, 2022
* build: install python3.8 in proxy build image

Signed-off-by: Yuchen Dai <lambdai@google.com>

* lint

Signed-off-by: Yuchen Dai <lambdai@google.com>

* remove duplicate ln -s python3

Signed-off-by: Yuchen Dai <lambdai@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proxy build is broken. update build-tools-proxy image

4 participants