Closed
Conversation
Signed-off-by: Yuchen Dai <lambdai@google.com>
Signed-off-by: Yuchen Dai <lambdai@google.com>
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/S
bianpengyuan
reviewed
Jun 6, 2021
Signed-off-by: Yuchen Dai <lambdai@google.com>
Contributor
Author
|
/retest |
Contributor
Author
|
/test test_proxy |
Contributor
Author
|
so far so good |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
/retest |
Contributor
Author
|
/test test_proxy |
Collaborator
|
@lambdai: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find build error while I am working on github.com/istio/tools/pull/1565
The goal of this PR is fix known errors with github.com/istio/tools/pull/1565 as a proof of success of building kafka network filters.
We may need more PRs to update the proxy code base to accommodate envoyproxy.
Signed-off-by: Yuchen Dai lambdai@google.com