Skip to content

Simplify prow configs by removing options with good defaults #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienvas merged 3 commits into from
Sep 27, 2018
Merged

Simplify prow configs by removing options with good defaults #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d199ccb
Update k8s.io/test-infra vendor
sebastienvas Sep 26, 2018
504ecdc
Update config to remove job value with default
sebastienvas Sep 26, 2018
4e63b82
Re-add contexts
sebastienvas Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Gopkg.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions prow/cluster/jobs/all-periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ test_infra_master_spec: &test_infra_master_spec
periodics:

- interval: 10m
agent: kubernetes
name: test-infra-cleanup-cluster
labels:
preset-service-account: "true"
Expand All @@ -24,7 +23,6 @@ periodics:
<<: *test_infra_master_spec

- interval: 10m
agent: kubernetes
name: test-infra-cleanup-cluster-release
labels:
preset-service-account: "true"
Expand All @@ -33,15 +31,13 @@ periodics:
<<: *test_infra_master_spec

- interval: 10m
agent: kubernetes
name: test-infra-cleanup-GKE
labels:
preset-service-account: "true"
spec:
<<: *test_infra_master_spec

- interval: 1h
agent: kubernetes
name: test-infra-update-deps
labels:
preset-service-account: "true"
Expand Down Expand Up @@ -71,7 +67,6 @@ periodics:
testing: test-pool

- interval: 30m
agent: kubernetes
name: green-build
labels:
preset-service-account: "true"
Expand Down Expand Up @@ -114,7 +109,6 @@ periodics:
testing: test-pool

- interval: 24h
agent: kubernetes
name: gcr_cleanup_istio_testing
labels:
preset-service-account: "true"
Expand Down
18 changes: 0 additions & 18 deletions ...r/jobs/istio-releases/daily-release/istio-releases.daily-release.collab-gcp-identity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,73 +33,55 @@ presubmits:
istio-releases/daily-release:

- name: daily-unit-tests
agent: kubernetes
context: prow/daily-unit-tests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-unit-tests"
trigger: "(?m)^/(retest|test (all|daily-unit-tests))?,?(\\s+|$)"
labels:
preset-service-account: "true"
preset-istio-kubeconfig: "true"
spec:
<<: *build_spec

- name: daily-e2e-pilot-no_auth
agent: kubernetes
context: prow/daily-e2e-pilot-no_auth.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-pilot-no_auth"
trigger: "(?m)^/(retest|test (all|daily-e2e-pilot-no_auth))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-bookinfoTests
agent: kubernetes
context: prow/daily-e2e-bookinfoTests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-bookinfo"
Copy link
Member

@cjwagner cjwagner Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will now default to /test daily-e2e-bookinfoTests.

Copy link
Contributor Author

@sebastienvas sebastienvas Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

trigger: "(?m)^/(retest|test (all|daily-e2e-bookinfo))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-simpleTests
agent: kubernetes
context: prow/daily-e2e-simpleTests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-simple"
Copy link
Member

@cjwagner cjwagner Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will default to /test daily-e2e-simpleTests

Copy link
Contributor Author

@sebastienvas sebastienvas Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that s fine. Prow will tell people what to do on the PR

trigger: "(?m)^/(retest|test (all|daily-e2e-simple))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-mixer-no_auth
agent: kubernetes
context: prow/daily-e2e-mixer-no_auth.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-mixer-no_auth"
trigger: "(?m)^/(retest|test (all|daily-e2e-mixer-no_auth))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-dashboard
agent: kubernetes
context: prow/daily-e2e-dashboard.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-dashboard"
trigger: "(?m)^/(retest|test (all|daily-e2e-dashboard))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
Expand Down
21 changes: 0 additions & 21 deletions prow/cluster/jobs/istio-releases/daily-release/istio-releases.daily-release.master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,85 +33,64 @@ presubmits:
istio-releases/daily-release:

- name: daily-perf-tests
agent: kubernetes
context: prow/daily-perf-tests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-perf-tests"
trigger: "(?m)^/(retest|test (all|daily-perf-tests))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-unit-tests
agent: kubernetes
context: prow/daily-unit-tests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-unit-tests"
trigger: "(?m)^/(retest|test (all|daily-unit-tests))?,?(\\s+|$)"
labels:
preset-service-account: "true"
preset-istio-kubeconfig: "true"
spec:
<<: *build_spec

- name: daily-e2e-pilot-no_auth
agent: kubernetes
context: prow/daily-e2e-pilot-no_auth.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-pilot-no_auth"
trigger: "(?m)^/(retest|test (all|daily-e2e-pilot-no_auth))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-bookinfoTests
agent: kubernetes
context: prow/daily-e2e-bookinfoTests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-bookinfo"
trigger: "(?m)^/(retest|test (all|daily-e2e-bookinfo))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-simpleTests
agent: kubernetes
context: prow/daily-e2e-simpleTests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-simple"
trigger: "(?m)^/(retest|test (all|daily-e2e-simple))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-mixer-no_auth
agent: kubernetes
context: prow/daily-e2e-mixer-no_auth.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-mixer-no_auth"
trigger: "(?m)^/(retest|test (all|daily-e2e-mixer-no_auth))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
<<: *test_spec

- name: daily-e2e-dashboard
agent: kubernetes
context: prow/daily-e2e-dashboard.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-dashboard"
trigger: "(?m)^/(retest|test (all|daily-e2e-dashboard))?,?(\\s+|$)"
labels:
preset-service-account: "true"
spec:
Expand Down
21 changes: 0 additions & 21 deletions prow/cluster/jobs/istio-releases/daily-release/istio-releases.daily-release.release-0.8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,79 +32,58 @@ presubmits:

istio-releases/daily-release:
- name: daily-perf-tests
agent: kubernetes
context: prow/daily-perf-tests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-perf-tests"
trigger: "(?m)^/(retest|test (all|daily-perf-tests))?,?(\\s+|$)"
labels:
preset-service-account: true
spec:
<<: *test_spec
- name: daily-unit-tests
agent: kubernetes
context: prow/daily-unit-tests.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-unit-tests"
trigger: "(?m)^/(retest|test (all|daily-unit-tests))?,?(\\s+|$)"
labels:
preset-service-account: true
preset-istio-kubeconfig: true
spec:
<<: *build_spec
- name: daily-pilot-e2e-envoyv2-v1alpha3
agent: kubernetes
context: prow/daily-pilot-e2e-envoyv2-v1alpha3.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-pilot-e2e-envoyv2-v1alpha3"
trigger: "(?m)^/(retest|test (all|daily-pilot-e2e-envoyv2-v1alpha3))?,?(\\s+|$)"
labels:
preset-service-account: true
spec:
<<: *test_spec
- name: daily-e2e-rbac-no_auth
agent: kubernetes
context: prow/daily-e2e-rbac-no_auth.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-rbac-no_auth"
trigger: "(?m)^/(retest|test (all|daily-e2e-rbac-no_auth))?,?(\\s+|$)"
labels:
preset-service-account: true
spec:
<<: *test_spec
- name: daily-e2e-rbac-no_auth-default
agent: kubernetes
context: prow/daily-e2e-rbac-no_auth-default.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-rbac-no_auth-default"
trigger: "(?m)^/(retest|test (all|daily-e2e-rbac-no_auth-default))?,?(\\s+|$)"
labels:
preset-service-account: true
spec:
<<: *test_spec
- name: daily-e2e-rbac-auth
agent: kubernetes
context: prow/daily-e2e-rbac-auth.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-rbac-auth"
trigger: "(?m)^/(retest|test (all|daily-e2e-rbac-auth))?,?(\\s+|$)"
labels:
preset-service-account: true
spec:
<<: *test_spec
- name: daily-e2e-rbac-auth-default
agent: kubernetes
context: prow/daily-e2e-rbac-auth-default.sh
branches: *branch_spec
always_run: true
rerun_command: "/test daily-e2e-rbac-auth-default"
trigger: "(?m)^/(retest|test (all|daily-e2e-rbac-auth-default))?,?(\\s+|$)"
labels:
preset-service-account: true
spec:
Expand Down
Loading