Simplify prow configs by removing options with good defaults#982
Simplify prow configs by removing options with good defaults#982sebastienvas merged 3 commits intoistio:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
|
cc @cjwagner |
sebastienvas
changed the title
|
|
||
| - name: daily-unit-tests | ||
| agent: kubernetes | ||
| context: prow/daily-unit-tests.sh |
There was a problem hiding this comment.
This will change the context name from prow/daily-unit-tests.sh to the default of daily-unit-tests. You probably don't want to change the context name as that would require a status context migration and changing repo required context settings.
I would leave the context field as is for now and just drop the other fields.
There was a problem hiding this comment.
its automatic we have branch protection set up. but yes I would prefer something like "prow: daily-unit-tests" to be consistent with circle-ci. I'll take your suggestion and do the rename of context in a different PR.
There was a problem hiding this comment.
Branch protection definitely makes things easier, but you may still need to deprecate any existing statuses for the old context to avoid confusing users. We have this tool for that: https://github.com/kubernetes/test-infra/tree/master/maintenance/migratestatus
| context: prow/daily-e2e-bookinfoTests.sh | ||
| branches: *branch_spec | ||
| always_run: true | ||
| rerun_command: "/test daily-e2e-bookinfo" |
There was a problem hiding this comment.
This will now default to /test daily-e2e-bookinfoTests.
| context: prow/daily-e2e-simpleTests.sh | ||
| branches: *branch_spec | ||
| always_run: true | ||
| rerun_command: "/test daily-e2e-simple" |
There was a problem hiding this comment.
This will default to /test daily-e2e-simpleTests
There was a problem hiding this comment.
Yeah that s fine. Prow will tell people what to do on the PR
|
I only reviewed the first few files, but the comments I left should be applicable to them all. |
|
@sebastienvas: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
trigger, context, re_run_command and agent have good default now.