Skip to content

Automation step 3#5054

Merged
istio-testing merged 7 commits intoistio:masterfrom
hanxiaop:step-3
Oct 18, 2023
Merged

Automation step 3#5054
istio-testing merged 7 commits intoistio:masterfrom
hanxiaop:step-3

Conversation

@hanxiaop
Copy link
Copy Markdown
Member

No description provided.

@hanxiaop hanxiaop requested a review from a team as a code owner October 17, 2023 20:01
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 17, 2023
@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Oct 17, 2023

Will compare this to #5052

Copy link
Copy Markdown
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on changes

value: "0"
- name: AUTOMATOR_ORG
value: istio
image: gcr.io/istio-testing/build-tools:release-1.20-ff93080f0b66b1649fd6f3bfa6b63f74be377937
Copy link
Copy Markdown
Contributor

@ericvn ericvn Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you keep the image since it's different than the one at the top of the file (build-tools-proxy).

@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Oct 17, 2023

prow/config/private-presets.yaml will also need some labels added:

- labels:
    preset-override-deps: "release-1.20-release"
  env:
  - name: DEPENDENCIES
    valueFrom:
      configMapKeyRef:
        name: release-1.20-release-deps
        key: dependencies
- labels:
    preset-override-deps: "release-1.20-istio"
  env:
  - name: DEPENDENCIES
    valueFrom:
      configMapKeyRef:
        name: release-1.20-istio-deps
        key: dependencies

@hanxiaop
Copy link
Copy Markdown
Member Author

Verified it’s the same as mine, so I just use @ericvn 's commits.

Copy link
Copy Markdown
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanxiaop and I worked through the changes in this PR and we had the same file changes when complete. It just happens that this PR has my commits. While I hate to approve my own changes, because there isn't another T&R maintainer around, I will approve this PR top allow the branch cutting to proceed.

@istio-testing istio-testing merged commit 15daf21 into istio:master Oct 18, 2023
@istio-testing
Copy link
Copy Markdown
Collaborator

@hanxiaop: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key istio-private.istio.io.release-1.20.gen.yaml using file prow/cluster/jobs/istio-private/istio.io/istio-private.istio.io.release-1.20.gen.yaml
  • key istio-private.istio.release-1.20.gen.yaml using file prow/cluster/jobs/istio-private/istio/istio-private.istio.release-1.20.gen.yaml
  • key istio-private.proxy.release-1.20.gen.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.release-1.20.gen.yaml
  • key istio-private.release-builder.release-1.20.gen.yaml using file prow/cluster/jobs/istio-private/release-builder/istio-private.release-builder.release-1.20.gen.yaml
  • key istio.api.release-1.20.gen.yaml using file prow/cluster/jobs/istio/api/istio.api.release-1.20.gen.yaml
  • key istio.client-go.release-1.20.gen.yaml using file prow/cluster/jobs/istio/client-go/istio.client-go.release-1.20.gen.yaml
  • key istio.common-files.release-1.20.gen.yaml using file prow/cluster/jobs/istio/common-files/istio.common-files.release-1.20.gen.yaml
  • key istio.enhancements.release-1.20.gen.yaml using file prow/cluster/jobs/istio/enhancements/istio.enhancements.release-1.20.gen.yaml
  • key istio.istio.io.release-1.20.gen.yaml using file prow/cluster/jobs/istio/istio.io/istio.istio.io.release-1.20.gen.yaml
  • key istio.istio.release-1.20.gen.yaml using file prow/cluster/jobs/istio/istio/istio.istio.release-1.20.gen.yaml
  • key istio.proxy.release-1.20.gen.yaml using file prow/cluster/jobs/istio/proxy/istio.proxy.release-1.20.gen.yaml
  • key istio.release-builder.release-1.20.gen.yaml using file prow/cluster/jobs/istio/release-builder/istio.release-builder.release-1.20.gen.yaml
  • key istio.tools.release-1.20.gen.yaml using file prow/cluster/jobs/istio/tools/istio.tools.release-1.20.gen.yaml
  • key istio.ztunnel.release-1.20.gen.yaml using file prow/cluster/jobs/istio/ztunnel/istio.ztunnel.release-1.20.gen.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hanxiaop hanxiaop mentioned this pull request Oct 18, 2023
30 tasks
@aryan16 aryan16 mentioned this pull request Jan 8, 2024
8 tasks
@zirain zirain mentioned this pull request Apr 19, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants