Skip to content

Automation Step #3 - manual#5052

Closed
ericvn wants to merge 7 commits intoistio:masterfrom
ericvn:Step3
Closed

Automation Step #3 - manual#5052
ericvn wants to merge 7 commits intoistio:masterfrom
ericvn:Step3

Conversation

@ericvn
Copy link
Copy Markdown
Contributor

@ericvn ericvn commented Oct 16, 2023

I just ran the branch cut automation against and then tweaked the resulting files per the wiki. Feel free to use this PR for comparison or even merge it if things look good.

@ericvn ericvn added the do-not-merge Block automatic merging of a PR. label Oct 16, 2023
@ericvn ericvn requested a review from a team as a code owner October 16, 2023 14:45
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 16, 2023
- --labels=auto-merge
- --modifier=update_envoy_dep
- --token-env
- --cmd=UPDATE_BRANCH=main scripts/update_envoy.sh
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line to change when Envoy creates the release-1.28 branch.

@ericvn ericvn mentioned this pull request Oct 17, 2023
@ericvn
Copy link
Copy Markdown
Contributor Author

ericvn commented Oct 18, 2023

Closed as #5054 contains the same changes.

@ericvn ericvn closed this Oct 18, 2023
@ericvn ericvn deleted the Step3 branch October 18, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Block automatic merging of a PR. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants