Add utils::Version object to remove version file in api_manager#9
Merged
qiwzhang merged 2 commits intoistio:masterfrom Dec 7, 2016
Merged
Add utils::Version object to remove version file in api_manager#9qiwzhang merged 2 commits intoistio:masterfrom
qiwzhang merged 2 commits intoistio:masterfrom
Conversation
kyessenov
approved these changes
Dec 7, 2016
qiwzhang
added a commit
that referenced
this pull request
Feb 16, 2018
Support attributes in the interface.
howardjohn
pushed a commit
that referenced
this pull request
Feb 11, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes
howardjohn
pushed a commit
to howardjohn/proxy
that referenced
this pull request
Feb 11, 2020
* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes (cherry picked from commit 859552a)
istio-testing
pushed a commit
that referenced
this pull request
Feb 11, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes (cherry picked from commit 859552a) Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>
rlenglet
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes
rlenglet
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes
istio-testing
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>
yangminzhu
pushed a commit
to yangminzhu/proxy
that referenced
this pull request
Feb 25, 2020
* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes
yangminzhu
pushed a commit
to yangminzhu/proxy
that referenced
this pull request
Feb 25, 2020
* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com>
istio-testing
pushed a commit
that referenced
this pull request
Feb 26, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>
istio-testing
pushed a commit
to istio-testing/proxy
that referenced
this pull request
Feb 26, 2020
* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com>
istio-testing
added a commit
that referenced
this pull request
Feb 26, 2020
* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>
kyessenov
pushed a commit
to kyessenov/proxy
that referenced
this pull request
Jul 12, 2022
telemetry: add filter to create peer info obj for internal chain
YaoZengzeng
pushed a commit
to YaoZengzeng/proxy
that referenced
this pull request
Oct 25, 2024
memset sockaddr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.