Use audiences field from AuthProvider if available by sarvaniv · Pull Request #11 · istio/proxy

sarvaniv · 2016-12-13T00:16:19Z

No description provided.

googlebot · 2016-12-13T00:16:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

* Remove protobuf based entry calls. * Add new file src/client_impl_test.cc * Updated comment * move time_v outside of union. * Fix format.

* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes

* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes (cherry picked from commit 859552a)

* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes (cherry picked from commit 859552a) Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>

* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes

* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>

* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes

* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>

* Fixed JWT CVE related to exact PATH matches (istio#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (istio#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* Fixed JWT CVE related to exact PATH matches (#9) * Fixed JWT CVE related to exact PATH matches Problem: The JWT filter when matching exact paths included query parameters which meant the JWT requirement could be bypassed by adding a "?" after the path. The API was intended to only work for URIs. Solution: The fix updates the match logic to only include URIs i.e. path stripped off the query section. Added unit tests to validate these cases. * Fixed formatting * Strip fragment of Path Added unit tests to validate combination of query & fragment * Fix lint * Minor refactoring and more unit test cases (#11) * Minor refactoring and more unit test cases * Lint fixes Signed-off-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Neeraj Poddar <nrjpoddar@gmail.com>

telemetry: set SharedWithUpstreamConnection on workload meta obj

Update master branch

Use audiences field from AuthProvider if available

be1206a

sarvaniv closed this Dec 13, 2016

sarvaniv deleted the bug_33486639 branch December 13, 2016 17:18

qiwzhang added a commit that referenced this pull request Feb 16, 2018

Remove protobuf based entry calls. (#11)

755b410

* Remove protobuf based entry calls. * Add new file src/client_impl_test.cc * Updated comment * move time_v outside of union. * Fix format.

JimmyCYJ mentioned this pull request Jan 15, 2019

Removes dangling pointer in capture list of lambda function. #2080

Merged

howardjohn mentioned this pull request Feb 11, 2020

Cherry-pick JWT CVE fix into 1.4 (#12) #2667

Merged

yangminzhu mentioned this pull request Feb 25, 2020

Cherry-pick JWT CVE fix into master #2716

Merged

kyessenov pushed a commit to kyessenov/proxy that referenced this pull request Jul 12, 2022

Merge pull request istio#11 from solo-io/filter-state-filter-fix-pr

c8b7e8e

telemetry: set SharedWithUpstreamConnection on workload meta obj

YaoZengzeng pushed a commit to YaoZengzeng/proxy that referenced this pull request Dec 27, 2024

Merge pull request istio#11 from YaoZengzeng/update

e5470ca

Update master branch

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use audiences field from AuthProvider if available#11

Use audiences field from AuthProvider if available#11
sarvaniv wants to merge 1 commit intoistio:masterfrom
sarvaniv:bug_33486639

sarvaniv commented Dec 13, 2016

Uh oh!

googlebot commented Dec 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sarvaniv commented Dec 13, 2016

Uh oh!

googlebot commented Dec 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants