Skip to content

[release-1.6] bazel_get_workspace_status: Allow users to override variables#2863

Merged
istio-testing merged 1 commit intoistio:release-1.6from
istio-testing:cherry-pick-2861-to-release-1.6
May 26, 2020
Merged

[release-1.6] bazel_get_workspace_status: Allow users to override variables#2863
istio-testing merged 1 commit intoistio:release-1.6from
istio-testing:cherry-pick-2861-to-release-1.6

Conversation

@istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented May 25, 2020

This is an automated cherry-pick of #2861

@istio-testing istio-testing requested a review from a team May 25, 2020 20:23
@istio-testing istio-testing added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 25, 2020
@istio-testing istio-testing mentioned this pull request May 25, 2020
Merged
@googlebot
Copy link
Collaborator

googlebot commented May 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels May 25, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2020
@jwendell
Copy link
Member

jwendell commented May 26, 2020

@googlebot I consent.

@googlebot
Copy link
Collaborator

googlebot commented May 26, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 26, 2020
@istio-testing istio-testing merged commit d2d90de into istio:release-1.6 May 26, 2020
brian-avery pushed a commit to brian-avery/proxy-istio that referenced this pull request Sep 11, 2020
@istio-testing @jwendell
bazel_get_workspace_status: Allow users to override variables (istio#…
d107f84 
…2863) (istio#27)

Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>

Co-authored-by: Istio Automation <istio.testing@gmail.com>
Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brian-avery brian-avery brian-avery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jwendell jwendell

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@istio-testing @googlebot @jwendell @brian-avery