bazel_get_workspace_status: Allow users to override variables#2861
Merged
istio-testing merged 1 commit intoistio:masterfrom May 25, 2020
Merged
bazel_get_workspace_status: Allow users to override variables#2861istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
|
😊 Welcome @jwendell! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
jwendell
added
the
cherrypick/release-1.6
Contributor
|
I am wondering why do you want to override this? |
Contributor
|
@jwendell I'm not strongly opposing to this, but what's the use case? |
Member
Author
|
Use case is to be able to build on non-git trees, and offer our own (downstream builders) notion of Status. Note that this kind of flexibility is already supported in istio/istio. |
bianpengyuan
approved these changes
May 25, 2020
Collaborator
|
In response to a cherrypick label: new pull request created: #2863 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.