Send dynamic metadata as part of report calls#2013
Send dynamic metadata as part of report calls#2013rshriram merged 7 commits intoistio:release-1.1from
Conversation
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
googlebot
added
the
cla: yes
|
temporary fix for istio/istio#9613 . At the moment, this should unblock the internal use case I have to stream custom attributes generated by internal codecs to mixer without having to fork Istio mixer filter code. Would be nice to have a cleaner solution. |
|
Only for tcp? Just curious, why not Http? |
|
Oh I can do the same for HTTP as well. |
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
|
@qiwzhang updated to add dynamic metadata to http as well. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiwzhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
|
New changes are detected. LGTM label has been removed. |
4 participants
Envoy filters can add arbitrary attributes to dynamicMetadata. Its useful to log this as part of reports (envoy's gRPC access logs and normal access logs already print this info).
I am send the metadata as a dumb string (serialized form of envoy.api.v2.core.Metadata). Right now, there is no support in mixer for this, but an adapter wishing to utilize this can deserialize this info and log this info, thus providing the ability for third party codecs to log additional attributes as part of a connection.
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com