Skip to content

add dynamic state to attribute list#684

Closed
rshriram wants to merge 1 commit intoistio:release-1.1from
rshriram:release-1.1
Closed

add dynamic state to attribute list#684
rshriram wants to merge 1 commit intoistio:release-1.1from
rshriram:release-1.1

Conversation

@rshriram
Copy link
Member

@rshriram rshriram commented Oct 31, 2018

This PR has no API level changes. It adds two new attributes (one for http and one for tcp, similar to the sni attribute added recently). These attributes correspond to the dynamic metadata generated in Envoy by various filters (metadata includes attributes and valuable logging info generated by various codecs).

related to istio/proxy#2013 and
istio/istio#9613

Signed-off-by: Shriram Rajagopalan shriramr@vmware.com

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 31, 2018
@rshriram rshriram requested review from douglas-reid and mandarjog and removed request for andraxylia and hklai October 31, 2018 14:13
Copy link
Contributor

@qiwzhang qiwzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Collaborator

@qiwzhang: changing LGTM is restricted to assignees, and only istio/api repo collaborators may be assigned issues.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qiwzhang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants