Skip to content

Fix typo#2946

Closed
pilhuhn wants to merge 1 commit intoistio:masterfrom
pilhuhn:patch-1
Closed

Fix typo#2946
pilhuhn wants to merge 1 commit intoistio:masterfrom
pilhuhn:patch-1

Conversation

@pilhuhn
Copy link
Copy Markdown

@pilhuhn pilhuhn commented Dec 4, 2018

spec.target should be spec.targets

spec.target should be spec.targets
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@istio-testing
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pilhuhn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu

If they are not already assigned, you can assign the PR to them by writing /assign @frankbu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Dec 4, 2018
@istio-testing
Copy link
Copy Markdown
Contributor

Hi @pilhuhn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pilhuhn
Copy link
Copy Markdown
Author

pilhuhn commented Dec 4, 2018

@googlebot CLA has been signed - I am part of Red Hat CLA

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Dec 4, 2018
@pilhuhn
Copy link
Copy Markdown
Author

pilhuhn commented Dec 4, 2018

/assign @frankbu

namespace: frod
spec:
target:
targets:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated documentation. It needs to be fixed here.

@pilhuhn pilhuhn closed this Dec 5, 2018
@pilhuhn
Copy link
Copy Markdown
Author

pilhuhn commented Dec 5, 2018

Thanks @frankbu

@pilhuhn pilhuhn deleted the patch-1 branch December 5, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants