Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pilhuhn If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @pilhuhn. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@googlebot CLA has been signed - I am part of Red Hat CLA |
|
CLAs look good, thanks! |
|
/assign @frankbu |
| namespace: frod | ||
| spec: | ||
| target: | ||
| targets: |
There was a problem hiding this comment.
This is generated documentation. It needs to be fixed here.
|
Thanks @frankbu |
spec.target should be spec.targets