Fix header corruption in sendLocalResponse (#606)#253
Merged
istio-testing merged 1 commit intoistio:release-1.7from Aug 6, 2020
Merged
Fix header corruption in sendLocalResponse (#606)#253istio-testing merged 1 commit intoistio:release-1.7from
istio-testing merged 1 commit intoistio:release-1.7from
Conversation
Now that WASM calls sendLocalReply as a deferred call, the collection of string_views that it uses to set headers on the new response points to invalid data. We have to make a copy of all the new headers before deferring the call. Signed-off-by: Gregory Brail <gregbrail@google.com>
jplevyak
approved these changes
Aug 6, 2020
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 19, 2021
Commit Message: Fixing a crash when the decoder receives an empty metadata map. Additional Description: Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode. The proposed fix ignores the empty metadata maps and updates a stats if one is received. Risk Level: Medium for Envoy's running with Metadata support. Testing: Added integration tests. Docs Changes: Added a codec stats counter description. Release Notes: Added bug fix description. Platform Specific Features: N/A. Fixes a fuzz bug: 25303 Signed-off-by: Tony Allen <tony@allen.gg>
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
Commit Message: Fixing a crash when the decoder receives an empty metadata map. Additional Description: Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode. The proposed fix ignores the empty metadata maps and updates a stats if one is received. Risk Level: Medium for Envoy's running with Metadata support. Testing: Added integration tests. Docs Changes: Added a codec stats counter description. Release Notes: Added bug fix description. Platform Specific Features: N/A. Fixes a fuzz bug: 25303 Signed-off-by: Tony Allen <tony@allen.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that WASM calls sendLocalReply as a deferred call, the
collection of string_views that it uses to set headers on the
new response points to invalid data. We have to make a copy of all
the new headers before deferring the call.
Signed-off-by: Gregory Brail gregbrail@google.com