Disambiguate smart pointer type aliases (#583).#606
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Mar 22, 2017
Merged
Disambiguate smart pointer type aliases (#583).#606mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Also updated CONTRIBUTING.md to codify the conventions, with a bonus few other style updates. Fixed envoyproxy#583.
Member
Author
mattklein123
approved these changes
Mar 22, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I feel somewhat guilty that you actually spent all the time doing this, but thanks. :)
Member
Author
|
It was pretty smooth actually, > 90% of the renames could be done with grep/sed/find :) Thanks for the review. |
| * Smart pointers are type aliased: | ||
| * `typedef std::unique_ptr<Foo> FooPtr;` | ||
| * `typedef std::shared_ptr<Bar> BarSharedPtr;` | ||
| * `typedef std::shareD_ptr<const Blah> BlahConstSharedPtr;` |
Member
There was a problem hiding this comment.
appears to be fixed already, nice :)
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 6, 2020
Now that WASM calls sendLocalReply as a deferred call, the collection of string_views that it uses to set headers on the new response points to invalid data. We have to make a copy of all the new headers before deferring the call. Signed-off-by: Gregory Brail <gregbrail@google.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Aug 6, 2020
Now that WASM calls sendLocalReply as a deferred call, the collection of string_views that it uses to set headers on the new response points to invalid data. We have to make a copy of all the new headers before deferring the call. Signed-off-by: Gregory Brail <gregbrail@google.com> Co-authored-by: Greg Brail <gbrail@users.noreply.github.com>
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 7, 2020
Now that WASM calls sendLocalReply as a deferred call, the collection of string_views that it uses to set headers on the new response points to invalid data. We have to make a copy of all the new headers before deferring the call. Signed-off-by: Gregory Brail <gregbrail@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: using distdir temporarily to fetch tclap while we firgure out #600 and update envoy. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: using distdir temporarily to fetch tclap while we firgure out #600 and update envoy. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Jan 18, 2023
…oyproxy#651) * build(deps): bump setuptools from 59.0.1 to 59.5.0 in /tools/base (envoyproxy#606) Bumps [setuptools](https://github.com/pypa/setuptools) from 59.0.1 to 59.5.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v59.0.1...v59.5.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump setuptools from 59.5.0 to 60.1.0 in /tools/base (envoyproxy#620) Bumps [setuptools](https://github.com/pypa/setuptools) from 59.5.0 to 60.1.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v59.5.0...v60.1.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add support for validating header keys and values fixes envoyproxy#627 Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * address PR feedback Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * add quic header key/value validation Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * add runtime guard: envoy.reloadable_features.validate_upstream_headers Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * honor runtime guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * update integration tests for invalid header key/value validation Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix http/2 integration tests for invalid header values Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * use nghttp2 for header name and value rfc compliance checks Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * bypass assertions to set invalid header key/value for protocol integration tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix bad merge on changelog Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix unit invalid header integration tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * add entry for new envoy.reloadable_features.validate_upstream_headers runtime guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * clarify validate_upstream_headers guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * disable validate_upstream_headers guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix build Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix unit tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix unit test Signed-off-by: Adam Meily <adam.meily@trailofbits.com> Signed-off-by: Adam Meily <adam.meily@trailofbits.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This deprecates the AIServiceBackend.Timeouts configuration that has started working not well with the refactored use of HTTPRoute since #599. Instead, this adds `timeouts` into AIGatewayRouteRule to matche the one of HTTPRoute in GWAPI. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated CONTRIBUTING.md to codify the conventions, with a bonus few other style updates.
Fixed #583.