add kubevirtInterfaces to istio CNI#91
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @tiswanso thanks for opening the cherry pick! |
|
@john-a-joyce -- I think this is good to go as well. The changes are identical to the istio-iptables.sh changes in istio/istio. The redirect.go stuff just adds the ability to control the kubevirt interface params to istio-iptables.sh from the pod annotation |
Cherry-pick #90 into master