Skip to content
This repository was archived by the owner on Jan 23, 2022. It is now read-only.

add kubevirtInterfaces to istio CNI#91

Merged
john-a-joyce merged 1 commit intoistio:masterfrom
tiswanso:kubevirt
Mar 7, 2019
Merged

add kubevirtInterfaces to istio CNI#91
john-a-joyce merged 1 commit intoistio:masterfrom
tiswanso:kubevirt

Conversation

@tiswanso
Copy link
Contributor

@tiswanso tiswanso commented Mar 6, 2019

Cherry-pick #90 into master

  • we're wanting to rebase release-1.1 on master since all deltas are compatible fixes for istio release-1.1

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tiswanso

If they are not already assigned, you can assign the PR to them by writing /assign @tiswanso in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiswanso tiswanso removed the request for review from baodongli March 6, 2019 19:24
@SchSeba
Copy link

SchSeba commented Mar 7, 2019

Hi @tiswanso thanks for opening the cherry pick!

@tiswanso tiswanso requested a review from john-a-joyce March 7, 2019 15:19
@tiswanso
Copy link
Contributor Author

tiswanso commented Mar 7, 2019

@john-a-joyce -- I think this is good to go as well. The changes are identical to the istio-iptables.sh changes in istio/istio. The redirect.go stuff just adds the ability to control the kubevirt interface params to istio-iptables.sh from the pod annotation traffic.sidecar.istio.io/kubevirtInterfaces. All the circleci tests are passing so it looks good from a sanity/collateral point of view.

@john-a-joyce john-a-joyce merged commit f1a08be into istio:master Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants