Skip to content
This repository was archived by the owner on Jan 23, 2022. It is now read-only.

add kubevirt interfaces to istio CNI#90

Closed
SchSeba wants to merge 1 commit intoistio:release-1.1from
SchSeba:internal_interfaces
Closed

add kubevirt interfaces to istio CNI#90
SchSeba wants to merge 1 commit intoistio:release-1.1from
SchSeba:internal_interfaces

Conversation

@SchSeba
Copy link

@SchSeba SchSeba commented Feb 28, 2019

Related to istio/istio#11321 and istio/istio#10378

add kubevirt interfaces annotation to istio cni

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiswanso tiswanso removed the request for review from baodongli February 28, 2019 23:03
@tiswanso
Copy link
Contributor

#88 is needed in the istio-cni release-1.1 branch for the tests on this PR to run. Will try to get that merged in and then will have you rebase

@SchSeba
Copy link
Author

SchSeba commented Mar 3, 2019

Hi @tiswanso thanks for the comment I saw #88 was merge to master there is any intention to merge it also for release 1.1?

@tiswanso
Copy link
Contributor

tiswanso commented Mar 6, 2019

@SchSeba could you just cherry-pick this onto master and we'll get it in there and merge it into 1.1?

@john-a-joyce
Copy link
Contributor

Closing this as on CNI we are committing only to master and pulling any needed commits form Master on to release 1.1. Since there is no direct linkage between istio 1.1 and CNI 1.1 now anyway. 99% of the time people will use CNI master unless specifically pegging a version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants