Skip to content

Rename "principals" to "names". #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshriram merged 2 commits into from
Feb 11, 2019
Merged

Rename "principals" to "names". #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bee2d1
Rename "principals" to "names".
liminw Feb 9, 2019
8152c07
Update comments.
liminw Feb 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5347,13 +5347,13 @@
},
{
"id": 4,
"name": "principals",
"name": "names",
"type": "string",
"is_repeated": true
},
{
"id": 5,
"name": "not_principals",
"name": "not_names",
"type": "string",
"is_repeated": true
},
Expand Down
159 changes: 80 additions & 79 deletions rbac/v1alpha1/rbac.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions rbac/v1alpha1/rbac.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,14 @@ message Subject {
string user = 1;

// $hide_from_docs
// Optional. A list of principals that the subject represents. This is matched to the
// `source.principal` attribute. If not specified, it applies to any principals.
repeated string principals = 4;
// Optional. A list of subject names. This is matched to the
// `source.principal` attribute. If one of subject names is "*", it matches to a subject with any name.
// Prefix and suffix matches are supported.
repeated string names = 4;

// $hide_from_docs
// Optional. A list of principals that must not be matched.
repeated string not_principals = 5;
// Optional. A list of subject names that must not be matched.
repeated string not_names = 5;

// $hide_from_docs
// Optional. The group that the subject belongs to.
Expand Down