fix proxy build broken by global_dictionary.yaml

[yangminzhu]

I made a comment in https://github.com/istio/api/pull/605/files but think it's faster to send out a PR directly.

@mandarjog
Line 316 - "-" break the proxy build as create_global_dictionary.py parse it to: ""-"", which is invalid in .cc file.

Could you suggest the proper way to fix this? Should we just remove the " or make it \"-\" or even update the script?

[istio-testing]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mandarjog]

@yangminzhu can you verify that the resulting file is still a valid yaml file?
There is a go generate command in istio/istio where mixer server generates go code from this.

@bianpengyuan You had faced an issue with -, and I thought we got rid of it.

[bianpengyuan]

@mandarjog instead of removing it, I added some logic to escape " in list generation code in istio/istio#8087.

[yangminzhu]

@bianpengyuan so I think the right way to fix is to also update create_global_dictionary.py to do the same escape? If so I'll update this PR as well. Thanks.

[bianpengyuan]

@yangminzhu Yes I think so. Let's do that.