Skip to content

Add proxy_error_code #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Aug 13, 2018
Merged

Add proxy_error_code #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions mixer/v1/global_dictionary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,3 +295,25 @@
# query_params is the normalized query part of a url.
- request.url_path
- request.query_params

# context.proxy_error_code = %RESPONSE_FLAGS% in envoy access logs.
# Other proxies should return equivalent error messages.
- context.proxy_error_code
# following are the RESPONSE_FLAGS supported by envoy as of 2018-08-10
# https://www.envoyproxy.io/docs/envoy/latest/configuration/access_log#configuration
- UH
- UF
- UO
- NR
- LH
- UT
- LR
- UR
- UC
- DI
- FI
- RL
- "-"
Copy link
Contributor

@yangminzhu yangminzhu Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandarjog
Line 316 - "-" break the proxy build as create_global_dictionary.py parse it to: ""-"", which is invalid in .cc.

Could you suggest the proper way to fix this? Should we just remove the " or make it \"-\" or even update the script?


- inbound
- outbound