[release-1.0] Add version alias support (#566)#662
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.0from Feb 18, 2025
Merged
[release-1.0] Add version alias support (#566)#662istio-testing merged 1 commit intoistio-ecosystem:release-1.0from
istio-testing merged 1 commit intoistio-ecosystem:release-1.0from
Conversation
* Refactor version management to use new istioversions package - Moved supportedversion into pkg/istioversions - Embeded versions.yaml into the binary - Updated Makefile and scripts to reference the new versions.yaml location in pkg/istioversions. - Replaced instances of supportedversion with istioversions in various controller tests and integration tests. Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Add alias support in istioversions Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Introduce alias in the controller Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix tests for alias Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix version value format Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Add comments to pkg/istioversions/versions.go Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Support for different versions YAML files Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Automatically update aliases Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Remove 'latest' and create an alias called 'master' Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Include alias as part of the installation tests Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Update tests Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Resolve version name for IstioCNI and ZTunnel Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Update tests Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Update types validation Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Apply suggestions in the reviews Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Change 'alias' to 'aliases' in version.yaml Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Skip sample pod specs when running under an alias version Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Make consistent naming Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix test style Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Change version.yaml structure Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Update tests and rename Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix tests Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Remove version alias in IstioRevision Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix a test The error was "no namespace specified" and the reconciliation of the active revision path was never entered. A namespace is added into the spec and the error in the `reconcileActiveRevision` path is triggered. Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix a rebase error Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Update field name to use `ref` Signed-off-by: Yann Liu <yannliu@redhat.com> * Simplify `versions.yaml` loading logic Signed-off-by: Yann Liu <yannliu@redhat.com> * Lint Signed-off-by: Yann Liu <yannliu@redhat.com> * Fix list_only_latest() func Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Introduce VERSIONS_YAML_PATH Signed-off-by: Yann Liu <yannliu@redhat.com> * Rename to istioversion Signed-off-by: Yann Liu <yannliu@redhat.com> * Reword error message Signed-off-by: Yann Liu <yannliu@redhat.com> * Fix update_alias() Signed-off-by: Yann Liu <yannliu@redhat.com> * Update package path references Signed-off-by: Yann Liu <yannliu@redhat.com> * Fix import error Signed-off-by: Yann Liu <yannliu@redhat.com> * Update versions.yaml definition In versions.yaml, `Ref` is now a reference to the name of a version. Signed-off-by: Yann Liu <yannliu@redhat.com> --------- Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #662 +/- ##
===============================================
- Coverage 74.44% 74.30% -0.14%
===============================================
Files 42 42
Lines 2559 2584 +25
===============================================
+ Hits 1905 1920 +15
- Misses 562 570 +8
- Partials 92 94 +2 ☔ View full report in Codecov by Sentry. |
dgn
approved these changes
Feb 18, 2025
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Feb 24, 2025
* upstream/release-1.0: Make environment variable consistent (openshift-service-mesh#664) Add multi control plane e2e tests (openshift-service-mesh#610) (openshift-service-mesh#670) Ensure e2e tests use the correct versions yaml file (openshift-service-mesh#667) (openshift-service-mesh#669) Add version alias support (openshift-service-mesh#566) (openshift-service-mesh#662) Add missing link for: Example using the RevisionBased strategy and an IstioRevisionTag # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
mkralik3
pushed a commit
to mkralik3/sail-operator
that referenced
this pull request
Mar 23, 2026
Co-authored-by: openshift-service-mesh-bot <null>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add alias support in istioversions
Introduce alias in the controller
Fix tests for alias
Fix version value format
Add comments to pkg/istioversions/versions.go
Support for different versions YAML files
Automatically update aliases
Remove 'latest' and create an alias called 'master'
Include alias as part of the installation tests
Update tests
Resolve version name for IstioCNI and ZTunnel
Update tests
Update types validation
Apply suggestions in the reviews
Change 'alias' to 'aliases' in version.yaml
Skip sample pod specs when running under an alias version
Make consistent naming
Fix test style
Change version.yaml structure
Update tests and rename
Fix tests
Remove version alias in IstioRevision
Fix a test
The error was "no namespace specified" and the reconciliation of the active revision path was never entered. A namespace is added into the spec and the error in the
reconcileActiveRevisionpath is triggered.Fix a rebase error
Update field name to use
refSimplify
versions.yamlloading logicLint
Fix list_only_latest() func
Introduce VERSIONS_YAML_PATH
Rename to istioversion
Reword error message
Fix update_alias()
Update package path references
Fix import error
Update versions.yaml definition
In versions.yaml,
Refis now a reference to the name of a version.