Fix commit check workflow to only check the first PR commit#1692
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Mar 16, 2026
Merged
Conversation
The commit-check github action was silently ignoring the "commit:" input. As a result, the action was checking all the commits. This PR fixes it by checking out the first commit of the PR before running the action, so that HEAD points to the correct commit when commit-check runs. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 80.87% 80.48% -0.40%
==========================================
Files 50 50
Lines 2479 2490 +11
==========================================
- Hits 2005 2004 -1
- Misses 349 357 +8
- Partials 125 129 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxBab
approved these changes
Mar 15, 2026
fjglira
approved these changes
Mar 16, 2026
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 17, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1696) Fix commit check workflow to only check the first PR commit (istio-ecosystem#1692) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1693) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1691) Fix infinite reconcile loop when Istio version is EOL (istio-ecosystem#1690) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1688) Give agents instructions on finalizing a change. (istio-ecosystem#1653) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1685) fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1681) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1672) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1668) Fix missing MaxConcurrentReconciles in ZTunnel controller (istio-ecosystem#1661)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 18, 2026
* upstream/main: Adding FIPS_CLUSTER variable to E2E test (istio-ecosystem#1698) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1696) Fix commit check workflow to only check the first PR commit (istio-ecosystem#1692) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1693) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1691) Fix infinite reconcile loop when Istio version is EOL (istio-ecosystem#1690) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1688) Give agents instructions on finalizing a change. (istio-ecosystem#1653) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1685) fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1681) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1672) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1668) Fix missing MaxConcurrentReconciles in ZTunnel controller (istio-ecosystem#1661)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-check github action was silently ignoring the "commit:" input. As a result, the action was checking all the commits. This PR fixes it by checking out the first commit of the PR before running the action, so that HEAD points to the correct commit when commit-check runs.