Fix infinite reconcile loop when Istio version is EOL#1690
Merged
istio-testing merged 2 commits intoistio-ecosystem:mainfrom Mar 13, 2026
Merged
Fix infinite reconcile loop when Istio version is EOL#1690istio-testing merged 2 commits intoistio-ecosystem:mainfrom
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
Conversation
When an EOL version is specified in the Istio CR, the Resolve() method returned a plain error. controller-runtime treated this as a retriable failure and kept reconciling with exponential backoff, resulting in an endless loop with "Reconciler error" logs. This PR fixes makes the following changes to the code. 1. Added IsEOLVersion() report a proper message in status conditions. 2. Wraps EOL errors as ValidationError and updates the Istio, IstioCNI and ZTunnel controllers. StandardReconciler already treats ValidationError as non-retriable, so it logs once and stops reconciling until the resource is updated. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Fixes: istio-ecosystem#1689
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
+ Coverage 80.87% 81.16% +0.28%
==========================================
Files 50 50
Lines 2479 2490 +11
==========================================
+ Hits 2005 2021 +16
+ Misses 349 347 -2
+ Partials 125 122 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgn
reviewed
Mar 13, 2026
Collaborator
dgn
left a comment
dgn
left a comment
There was a problem hiding this comment.
Thank you @sridhargaddam, this LGTM. Can you adjust the failing integration test so that instead of checking for the specific error, it verifies that no reconcile loop is taking place?
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dgn
approved these changes
Mar 13, 2026
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 16, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1693) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1691) Fix infinite reconcile loop when Istio version is EOL (istio-ecosystem#1690) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1688) Give agents instructions on finalizing a change. (istio-ecosystem#1653) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1685) fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1681) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1672) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1668) Fix missing MaxConcurrentReconciles in ZTunnel controller (istio-ecosystem#1661)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 17, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1696) Fix commit check workflow to only check the first PR commit (istio-ecosystem#1692) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1693) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1691) Fix infinite reconcile loop when Istio version is EOL (istio-ecosystem#1690) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1688) Give agents instructions on finalizing a change. (istio-ecosystem#1653) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1685) fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1681) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1672) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1668) Fix missing MaxConcurrentReconciles in ZTunnel controller (istio-ecosystem#1661)
Contributor
Author
|
@team, shall we backport this fix to release branches? |
Collaborator
|
I would say we should. At least to the latest release branch. Adding the label. I don't think we need this in downstream as we don't use EOL there so we probably don't need it in older releases. |
Collaborator
|
In response to a cherrypick label: new pull request created: #1709 |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 18, 2026
* upstream/main: Adding FIPS_CLUSTER variable to E2E test (istio-ecosystem#1698) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1696) Fix commit check workflow to only check the first PR commit (istio-ecosystem#1692) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1693) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1691) Fix infinite reconcile loop when Istio version is EOL (istio-ecosystem#1690) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1688) Give agents instructions on finalizing a change. (istio-ecosystem#1653) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1685) fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1681) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1672) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1668) Fix missing MaxConcurrentReconciles in ZTunnel controller (istio-ecosystem#1661)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an EOL version is specified in the
IstioCR, theResolve()method returned a plain error. controller-runtime treated this as a retriable failure and kept reconciling with exponential backoff, resulting in an endless loop with "Reconciler error" logs.This PR fixes makes the following changes to the code.
ValidationErrorand updates theIstio,IstioCNIandZTunnelcontrollers. StandardReconciler already treatsValidationErroras non-retriable, so it logs once and stops reconciling until the resource is updated.Fixes: #1689