Skip to content

[release-1.28] fix: write correct helm value for FIPS-140-2 support#1682

Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing:cherry-pick-1681-to-release-1.28
Mar 11, 2026
Merged

[release-1.28] fix: write correct helm value for FIPS-140-2 support#1682
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing:cherry-pick-1681-to-release-1.28

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Mar 11, 2026

This is an automated cherry-pick of #1681

@dgn @istio-testing
fix: write correct helm value for FIPS-140-2 support
fd4cc1d 
Unfortunately, because of how we handle the helm values, setting
`ztunnel.env` does not work, it has to be `env` directly.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@istio-testing istio-testing requested a review from a team as a code owner March 11, 2026 12:03
@istio-testing istio-testing mentioned this pull request Mar 11, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.05%. Comparing base (9fa7731) to head (fd4cc1d).
⚠️ Report is 1 commits behind head on release-1.28.

Files with missing lines Patch % Lines
pkg/istiovalues/fips.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.28    #1682      +/-   ##
================================================
+ Coverage         80.92%   81.05%   +0.12%     
================================================
  Files                44       44              
  Lines              2312     2312              
================================================
+ Hits               1871     1874       +3     
+ Misses              323      321       -2     
+ Partials            118      117       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkralik3
Copy link
Copy Markdown
Contributor

mkralik3 commented Mar 11, 2026

/test e2e-kind-dualstack

@istio-testing istio-testing merged commit e1b9c54 into istio-ecosystem:release-1.28 Mar 11, 2026
18 of 19 checks passed
cam-garrison pushed a commit to cam-garrison/sail-operator that referenced this pull request Mar 11, 2026
@istio-testing @dgn @cam-garrison
fix: write correct helm value for FIPS-140-2 support (istio-ecosystem…
18d8cf5 
…#1682)

Unfortunately, because of how we handle the helm values, setting
`ztunnel.env` does not work, it has to be `env` directly.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
cam-garrison pushed a commit to cam-garrison/sail-operator that referenced this pull request Mar 11, 2026
@istio-testing @dgn @cam-garrison
fix: write correct helm value for FIPS-140-2 support (istio-ecosystem…
b3ab70e 
…#1682)

Unfortunately, because of how we handle the helm values, setting
`ztunnel.env` does not work, it has to be `env` directly.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
This was referenced Mar 11, 2026
Merged
Merged
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
be93599 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
9b02f0a 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
f6ceb9d 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
7ea29ef 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
11fabdd 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
4f34208 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-merge-bot bot pushed a commit to openshift-service-mesh/sail-operator that referenced this pull request Mar 12, 2026
@cam-garrison @istio-testing @dgn
[release-3.3.0] fix: write correct helm value for FIPS-140-2 support (#…
aff5658 
…715)

* fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)

Unfortunately, because of how we handle the helm values, setting
`ztunnel.env` does not work, it has to be `env` directly.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>

* bump istio hash

Signed-off-by: Cameron Garrison <cgarriso@redhat.com>

---------

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: Cameron Garrison <cgarriso@redhat.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-service-mesh/sail-operator that referenced this pull request Mar 16, 2026
@cam-garrison @istio-testing @dgn
fix: write correct helm value for FIPS-140-2 support (istio-ecosystem…
47ec64b 
…#1682) (#716)

Unfortunately, because of how we handle the helm values, setting
`ztunnel.env` does not work, it has to be `env` directly.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgn dgn dgn approved these changes

Assignees

No one assigned

Labels

release-notes-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@istio-testing @mkralik3 @dgn