Skip to content

[release-1.28] Fix infinite reconciliation on webhook resources#1660

Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing:cherry-pick-1651-to-release-1.28
Mar 10, 2026
Merged

[release-1.28] Fix infinite reconciliation on webhook resources#1660
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing:cherry-pick-1651-to-release-1.28

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Mar 6, 2026

This is an automated cherry-pick of #1651

@dgn @istio-testing
Fix infinite reconciliation on webhook resources
402ed92 
istiod updates the CABundle and FailurePolicy on its
ValidatingWebhookConfigurations and MutatingWebhookConfigurations. The
controller needs to ignore those changes to avoid continuous
reconciliation of the control plane.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@istio-testing istio-testing requested a review from a team as a code owner March 6, 2026 16:34
@istio-testing istio-testing mentioned this pull request Mar 6, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.62%. Comparing base (7ab5002) to head (402ed92).
⚠️ Report is 2 commits behind head on release-1.28.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.28    #1660      +/-   ##
================================================
- Coverage         81.01%   80.62%   -0.40%     
================================================
  Files                44       44              
  Lines              2307     2312       +5     
================================================
- Hits               1869     1864       -5     
- Misses              322      328       +6     
- Partials            116      120       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sridhargaddam
Copy link
Copy Markdown
Contributor

sridhargaddam commented Mar 10, 2026

/test integ-tests-arm64

@istio-testing istio-testing merged commit 2d15299 into istio-ecosystem:release-1.28 Mar 10, 2026
18 of 19 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
Automated merge
9ccb8f7 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
Automated merge
6116b28 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
Automated merge
a647194 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
Automated merge
de56ee9 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
ce037e7 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
154df7e 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
e382153 
* upstream/release-1.28:
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
5aa083d 
* upstream/release-1.28:
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
be93599 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
Automated merge
9b02f0a 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
f6ceb9d 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
7ea29ef 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
11fabdd 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 12, 2026
Automated merge
4f34208 
* upstream/release-1.28:
  fix: write correct helm value for FIPS-140-2 support (istio-ecosystem#1682)
  [release-1.28] Added istio 1.28.5 and 1.27.8 (istio-ecosystem#1675)
  Fix infinite reconciliation on webhook resources (istio-ecosystem#1660)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1664)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgn dgn dgn approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

Assignees

No one assigned

Labels

release-notes-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@istio-testing @sridhargaddam @dgn