Skip to content

Backport scorecard test fix#1667

Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.0from
MaxBab:backport_scorecard_test_fix
Mar 9, 2026
Merged

Backport scorecard test fix#1667
istio-testing merged 2 commits intoistio-ecosystem:release-1.0from
MaxBab:backport_scorecard_test_fix

Conversation

@MaxBab
Copy link
Copy Markdown
Collaborator

@MaxBab MaxBab commented Mar 9, 2026

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Running on CI againt OCP cluster can be set by using OCP=true make test.scorecard

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

istio-ecosystem#1589)

* Improve scorecard test to avoid running on kind cluster inside OCP clusters

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Adding default values to scorecard test

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* CHange from review

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@MaxBab MaxBab requested a review from a team as a code owner March 9, 2026 11:34
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.55%. Comparing base (ae85b6f) to head (3368b9b).
⚠️ Report is 1 commits behind head on release-1.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0    #1667      +/-   ##
===============================================
+ Coverage        75.45%   75.55%   +0.09%     
===============================================
  Files               43       43              
  Lines             2086     2086              
===============================================
+ Hits              1574     1576       +2     
+ Misses             416      415       -1     
+ Partials            96       95       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Scorecard test fails with "namespace not found".
Make sure the namespace is created before executing the scorecard flow.

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
@MaxBab MaxBab force-pushed the backport_scorecard_test_fix branch from 692ff4f to 3368b9b Compare March 9, 2026 11:40
@MaxBab
Copy link
Copy Markdown
Collaborator Author

MaxBab commented Mar 9, 2026

/test e2e-kind-dualstack

@MaxBab
Copy link
Copy Markdown
Collaborator Author

MaxBab commented Mar 9, 2026

/retest

@MaxBab
Copy link
Copy Markdown
Collaborator Author

MaxBab commented Mar 9, 2026

/test e2e-kind-olm

@istio-testing istio-testing merged commit 2ec53c4 into istio-ecosystem:release-1.0 Mar 9, 2026
18 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 9, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
@MaxBab MaxBab deleted the backport_scorecard_test_fix branch March 9, 2026 13:43
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 9, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 9, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 10, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Mar 11, 2026
* upstream/release-1.0:
  Backport scorecard test fix (istio-ecosystem#1667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants