Improve scorecard test to avoid running on kind cluster inside OCP cl… by fjglira · Pull Request #1589 · istio-ecosystem/sail-operator

fjglira · 2026-02-11T10:20:37Z

…usters

What type of PR is this?

What this PR does / why we need it:

Running on CI againt OCP cluster can be set by using OCP=true make test.scorecard

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

…usters Signed-off-by: Francisco Herrera <fjglira@gmail.com>

codecov · 2026-02-11T10:24:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (871f07e) to head (53059e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
+ Coverage   80.75%   81.20%   +0.44%     
==========================================
  Files          50       50              
  Lines        2458     2458              
==========================================
+ Hits         1985     1996      +11     
+ Misses        348      341       -7     
+ Partials      125      121       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

FilipB · 2026-02-11T10:27:22Z

tests/scorecard-test.sh

+if [[ "${OCP}" == "true" ]]; then
+    NAMESPACE="${SCORECARD_NAMESPACE:-scorecard-test}"
+    # Create namespace if it doesn't exist
+    oc create namespace "${NAMESPACE}" --dry-run=client -o yaml | oc apply -f -


Why not using simple oc create namespace?

oc create namespace xxxx |true to avoid failing the test can work also

Let's use that as it's what we do in other parts as well

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

istio-testing · 2026-02-11T10:52:15Z

In response to a cherrypick label: new pull request created: #1590

istio-testing · 2026-02-11T10:52:52Z

In response to a cherrypick label: new pull request created: #1591

istio-testing · 2026-02-11T10:53:29Z

In response to a cherrypick label: new pull request created: #1592

* upstream/main: (38 commits) Improve scorecard test to avoid running on kind cluster inside OCP cl… (istio-ecosystem#1589) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1587) Adding TARGET_ARCH to tag definition when run on CI true (istio-ecosystem#1583) Expose "peerCaCrl" Ztunnel param added in Helm (istio-ecosystem#1578) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1579) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1577) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1576) feat(helm): add RenderChart functions for template rendering (istio-ecosystem#1575) refactor: extract shared reconciliation logic into pkg/reconcile (istio-ecosystem#1572) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1573) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1571) Add automation for updating EOL Istio versions (istio-ecosystem#1562) Fix e2e midstream CI mode (istio-ecosystem#1564) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1565) Migrate to fs.FS as the sole resource loading interface (istio-ecosystem#1561) Adding documentation for zero downtime ztunnel upgrade (istio-ecosystem#1552) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1563) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1560) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1559) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1558) ...

* upstream/main: (39 commits) Add Claude /refactor command for code improvements (istio-ecosystem#1489) Improve scorecard test to avoid running on kind cluster inside OCP cl… (istio-ecosystem#1589) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1587) Adding TARGET_ARCH to tag definition when run on CI true (istio-ecosystem#1583) Expose "peerCaCrl" Ztunnel param added in Helm (istio-ecosystem#1578) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1579) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1577) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1576) feat(helm): add RenderChart functions for template rendering (istio-ecosystem#1575) refactor: extract shared reconciliation logic into pkg/reconcile (istio-ecosystem#1572) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1573) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1571) Add automation for updating EOL Istio versions (istio-ecosystem#1562) Fix e2e midstream CI mode (istio-ecosystem#1564) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1565) Migrate to fs.FS as the sole resource loading interface (istio-ecosystem#1561) Adding documentation for zero downtime ztunnel upgrade (istio-ecosystem#1552) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1563) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1560) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1559) ...

istio-ecosystem#1589) * Improve scorecard test to avoid running on kind cluster inside OCP clusters Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding default values to scorecard test Signed-off-by: Francisco Herrera <fjglira@gmail.com> * CHange from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Improve scorecard test to avoid running on kind cluster inside OCP cl… (#1589) * Improve scorecard test to avoid running on kind cluster inside OCP clusters Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding default values to scorecard test Signed-off-by: Francisco Herrera <fjglira@gmail.com> * CHange from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix scorecard test failure (#1598) Scorecard test fails with "namespace not found". Make sure the namespace is created before executing the scorecard flow. Signed-off-by: Maxim Babushkin <mbabushk@redhat.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Signed-off-by: Maxim Babushkin <mbabushk@redhat.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com>

istio-ecosystem#1589) * Improve scorecard test to avoid running on kind cluster inside OCP clusters Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding default values to scorecard test Signed-off-by: Francisco Herrera <fjglira@gmail.com> * CHange from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

Improve scorecard test to avoid running on kind cluster inside OCP cl…

db19030

…usters Signed-off-by: Francisco Herrera <fjglira@gmail.com>

fjglira requested a review from a team as a code owner February 11, 2026 10:20

istio-testing added the size/M label Feb 11, 2026

Adding default values to scorecard test

b1e3930

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

FilipB reviewed Feb 11, 2026

View reviewed changes

fjglira added cherrypick/release-1.26 cherrypick/release-1.27 cherrypick/release-1.28 labels Feb 11, 2026

CHange from review

53059e1

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

FilipB approved these changes Feb 11, 2026

View reviewed changes

istio-testing merged commit 1747f2d into istio-ecosystem:main Feb 11, 2026
16 of 17 checks passed

istio-testing mentioned this pull request Feb 11, 2026

[release-1.26] Improve scorecard test to avoid running on kind cluster inside OCP cl… #1590

Merged

istio-testing mentioned this pull request Feb 11, 2026

[release-1.27] Improve scorecard test to avoid running on kind cluster inside OCP cl… #1591

Merged

istio-testing mentioned this pull request Feb 11, 2026

[release-1.28] Improve scorecard test to avoid running on kind cluster inside OCP cl… #1592

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve scorecard test to avoid running on kind cluster inside OCP cl…#1589

Improve scorecard test to avoid running on kind cluster inside OCP cl…#1589
istio-testing merged 3 commits intoistio-ecosystem:mainfrom
fjglira:improve-scorecard

fjglira commented Feb 11, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

FilipB Feb 11, 2026

Uh oh!

fjglira Feb 11, 2026

Uh oh!

FilipB Feb 11, 2026

Uh oh!

fjglira Feb 11, 2026

Uh oh!

Uh oh!

istio-testing commented Feb 11, 2026

Uh oh!

istio-testing commented Feb 11, 2026

Uh oh!

istio-testing commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fjglira commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Additional information:

Uh oh!

codecov bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

FilipB Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

fjglira Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

FilipB Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

fjglira Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

istio-testing commented Feb 11, 2026

Uh oh!

istio-testing commented Feb 11, 2026

Uh oh!

istio-testing commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fjglira commented Feb 11, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited

Loading