[release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (#1596)#1606
Conversation
…osystem#1596) * Enable TLSv1.2 for ZTunnel when in FIPS mode This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when `TLS12_ENABLED` is set to `true`. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Make sure that FipsEnabled is restored to original value In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
|
Hi @zmiklank. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.27 #1606 +/- ##
================================================
+ Coverage 80.35% 80.38% +0.02%
================================================
Files 44 44
Lines 2291 2299 +8
================================================
+ Hits 1841 1848 +7
Misses 330 330
- Partials 120 121 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
879d9c1
into
istio-ecosystem:release-1.27
* upstream/release-1.27: [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
* upstream/release-1.27: [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
* upstream/release-1.27: [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when
TLS12_ENABLEDis set totrue. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it.In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup.
Cherry-pick of #1547