Skip to content

[release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (#1596)#1606

Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.27from
zmiklank:cherrypick-tls12-ztunnel
Feb 17, 2026
Merged

[release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (#1596)#1606
istio-testing merged 1 commit intoistio-ecosystem:release-1.27from
zmiklank:cherrypick-tls12-ztunnel

Conversation

@zmiklank
Copy link
Copy Markdown
Contributor

@zmiklank zmiklank commented Feb 17, 2026

  • Enable TLSv1.2 for ZTunnel when in FIPS mode

This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when TLS12_ENABLED is set to true. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it.

  • Make sure that FipsEnabled is restored to original value

In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup.

Cherry-pick of #1547

…osystem#1596)

* Enable TLSv1.2 for ZTunnel when in FIPS mode

This change builds on istio/ztunnel#1711 which
adds TLSv1.2 support to ZTunnel when `TLS12_ENABLED` is set to `true`.
This patch will always set the env var when in FIPS mode, for all
versions of ZTunnel, even though it is only supported from 1.29+, but
the env var will simply be ignored by versions that don't support it.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Make sure that FipsEnabled is restored to original value

In our tests, we sometimes set FipsEnabled manually. We should make sure
to reset it to its original value during test cleanup.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

---------

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @zmiklank. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.38%. Comparing base (2c88e1d) to head (e4cde64).
⚠️ Report is 1 commits behind head on release-1.27.

Files with missing lines Patch % Lines
controllers/ztunnel/ztunnel_controller.go 33.33% 1 Missing and 1 partial ⚠️
pkg/istiovalues/fips.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #1606      +/-   ##
================================================
+ Coverage         80.35%   80.38%   +0.02%     
================================================
  Files                44       44              
  Lines              2291     2299       +8     
================================================
+ Hits               1841     1848       +7     
  Misses              330      330              
- Partials            120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sridhargaddam
Copy link
Copy Markdown
Contributor

/ok-to-test

Copy link
Copy Markdown
Contributor

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@istio-testing istio-testing merged commit 879d9c1 into istio-ecosystem:release-1.27 Feb 17, 2026
17 of 18 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Feb 17, 2026
* upstream/release-1.27:
  [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Feb 17, 2026
* upstream/release-1.27:
  [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Feb 17, 2026
* upstream/release-1.27:
  [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants