[release-1.28] Enable TLSv1.2 for ZTunnel when in FIPS mode#1596
Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.28from Feb 12, 2026
Merged
[release-1.28] Enable TLSv1.2 for ZTunnel when in FIPS mode#1596istio-testing merged 2 commits intoistio-ecosystem:release-1.28from
istio-testing merged 2 commits intoistio-ecosystem:release-1.28from
Conversation
This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when `TLS12_ENABLED` is set to `true`. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #1596 +/- ##
================================================
+ Coverage 71.22% 80.84% +9.61%
================================================
Files 39 44 +5
Lines 2040 2307 +267
================================================
+ Hits 1453 1865 +412
+ Misses 424 324 -100
+ Partials 163 118 -45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nrfox
approved these changes
Feb 12, 2026
istio-testing
merged commit f193af7
into
istio-ecosystem:release-1.28
18 of 19 checks passed
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 12, 2026
* upstream/release-1.28: [release-1.28] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596)
zmiklank
pushed a commit
to zmiklank/sail-operator
that referenced
this pull request
Feb 17, 2026
…osystem#1596) * Enable TLSv1.2 for ZTunnel when in FIPS mode This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when `TLS12_ENABLED` is set to `true`. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Make sure that FipsEnabled is restored to original value In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
zmiklank
pushed a commit
to zmiklank/sail-operator
that referenced
this pull request
Feb 17, 2026
…osystem#1596) * Enable TLSv1.2 for ZTunnel when in FIPS mode This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when `TLS12_ENABLED` is set to `true`. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Make sure that FipsEnabled is restored to original value In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
istio-testing
pushed a commit
that referenced
this pull request
Feb 17, 2026
…1606) * Enable TLSv1.2 for ZTunnel when in FIPS mode This change builds on istio/ztunnel#1711 which adds TLSv1.2 support to ZTunnel when `TLS12_ENABLED` is set to `true`. This patch will always set the env var when in FIPS mode, for all versions of ZTunnel, even though it is only supported from 1.29+, but the env var will simply be ignored by versions that don't support it. * Make sure that FipsEnabled is restored to original value In our tests, we sometimes set FipsEnabled manually. We should make sure to reset it to its original value during test cleanup. --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 17, 2026
* upstream/release-1.27: [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 17, 2026
* upstream/release-1.27: [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 17, 2026
* upstream/release-1.27: [release-1.27] Enable TLSv1.2 for ZTunnel when in FIPS mode (istio-ecosystem#1596) (istio-ecosystem#1606)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1547