Updating migration from sidecar to Ambient mode from review by fjglira · Pull Request #1294 · istio-ecosystem/sail-operator

fjglira · 2025-10-21T16:41:47Z

Adding some minors changes from review

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

codecov · 2025-10-21T16:45:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.80%. Comparing base (beff729) to head (4599a61).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   77.48%   77.80%   +0.31%     
==========================================
  Files          44       44              
  Lines        2834     2834              
==========================================
+ Hits         2196     2205       +9     
+ Misses        529      522       -7     
+ Partials      109      107       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

docs/migrate-from-sidecar-to-ambient/migration.adoc

mkralik3

Please fix the link for coexistence doc, still doesn't work for me

Adding some minors changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix format in list Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Enchancements Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Co-authored-by: Matej Kralik <mkralik@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com>

mkralik3 · 2025-10-21T18:25:28Z

/test e2e-kind-dualstack

Adding message for labeling namespaces Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* upstream/main: (39 commits) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) fix: add v1.26.1 version (istio-ecosystem#1301) Make sure a correct helm values file is used (istio-ecosystem#1297) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1303) Small change in the migration from sidecar to ambient doc (istio-ecosystem#1300) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1296) Updating migration from sidecar to Ambient mode from review (istio-ecosystem#1294) Update sidecar to ambient migration doc (istio-ecosystem#1295) ...

* upstream/main: (40 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) fix: add v1.26.1 version (istio-ecosystem#1301) Make sure a correct helm values file is used (istio-ecosystem#1297) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1303) Small change in the migration from sidecar to ambient doc (istio-ecosystem#1300) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1296) Updating migration from sidecar to Ambient mode from review (istio-ecosystem#1294) ...

…osystem#1294) * Updating migration from sidecar to Ambient mode from review Adding some minors changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Update format Fix format in list Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding some more enchance from review Enchancements Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix list format Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix list format Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix list format Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Update docs/migrate-from-sidecar-to-ambient/migration.adoc Co-authored-by: Matej Kralik <mkralik@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Update from review Adding message for labeling namespaces Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Matej Kralik <mkralik@redhat.com> Signed-off-by: Rafael Zago <rafaelvzago@gmail.com>

…osystem#1294) * Updating migration from sidecar to Ambient mode from review Adding some minors changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Update format Fix format in list Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding some more enchance from review Enchancements Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix list format Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix list format Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix list format Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Update docs/migrate-from-sidecar-to-ambient/migration.adoc Co-authored-by: Matej Kralik <mkralik@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Update from review Adding message for labeling namespaces Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Matej Kralik <mkralik@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

fjglira requested a review from a team as a code owner October 21, 2025 16:41

istio-testing added the size/M label Oct 21, 2025

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Outdated Show resolved Hide resolved

mkralik3 self-requested a review October 21, 2025 17:58

mkralik3 requested changes Oct 21, 2025

View reviewed changes

fjglira and others added 7 commits October 21, 2025 20:00

Updating migration from sidecar to Ambient mode from review

c706b31

Adding some minors changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Update format

25c0546

Fix format in list Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Adding some more enchance from review

746b29b

Enchancements Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix list format

939015e

Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix list format

7280e18

Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix list format

6204b95

Fix list format Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Update docs/migrate-from-sidecar-to-ambient/migration.adoc

0d977a6

Co-authored-by: Matej Kralik <mkralik@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com>

fjglira force-pushed the improve-migration-docs branch from 1636933 to 0d977a6 Compare October 21, 2025 18:00

mkralik3 self-requested a review October 21, 2025 18:12

Update from review

4599a61

Adding message for labeling namespaces Signed-off-by: Francisco Herrera <fjglira@gmail.com>

mkralik3 approved these changes Oct 21, 2025

View reviewed changes

istio-testing merged commit 8d7a67f into istio-ecosystem:main Oct 21, 2025
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating migration from sidecar to Ambient mode from review#1294

Updating migration from sidecar to Ambient mode from review#1294
istio-testing merged 8 commits intoistio-ecosystem:mainfrom
fjglira:improve-migration-docs

fjglira commented Oct 21, 2025

Uh oh!

codecov bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

mkralik3 left a comment •

edited

Loading

Uh oh!

mkralik3 commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fjglira commented Oct 21, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Additional information:

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mkralik3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkralik3 commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 21, 2025 •

edited

Loading

mkralik3 left a comment •

edited

Loading