Update Ztunnel config CRD flags by MaxBab · Pull Request #1117 · istio-ecosystem/sail-operator

MaxBab · 2025-08-13T09:11:58Z

What type of PR is this?

What this PR does / why we need it:

Update the following missing CRD flags for ztunnel config:

Affinity
Network
Tolerations
ResourceQuotas
seLinuxOptions
UpdateStrategy
NodeSelector

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/OSSM-9663

Additional information:

codecov · 2025-08-13T09:21:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.60%. Comparing base (2543fb8) to head (c1cade2).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   77.69%   78.60%   +0.90%     
==========================================
  Files          44       44              
  Lines        2834     2253     -581     
==========================================
- Hits         2202     1771     -431     
+ Misses        525      372     -153     
- Partials      107      110       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MaxBab · 2025-08-19T05:27:11Z

Hi @dgn @sridhargaddam

Could you take a look on the pr, please?

MaxBab · 2025-08-31T06:25:09Z

Hi @dgn

Appreciate your review here.

api/v1/values_types_extra.go

MaxBab · 2025-09-09T15:52:38Z

/test commit-check

FilipB · 2025-09-11T14:12:28Z

@MaxBab Do you think this will be needed in release-1.26?

MaxBab · 2025-09-11T17:23:13Z

@MaxBab Do you think this will be needed in release-1.26?

No.
Ambient mode is tech preview in 1.26.
No reason to backport this.

dgn · 2025-09-24T14:16:45Z

api/v1/values_types_extra.go

+	SeLinuxOptions *k8sv1.SELinuxOptions `json:"seLinuxOptions,omitempty"`
+	// K8s DaemonSet update strategy
+	// https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec).
+	UpdateStrategy *IstioUpdateStrategy `json:"updateStrategy,omitempty"`


This seems to be the wrong type, though? the IstioUpdateStrategy type is just RevisionBased vs InPlace, not any k8s type

@dgn

Hi Daniel,

I've modified the UpdateStrategy according to the Istio example:
https://github.com/istio-ecosystem/sail-operator/blob/main/api/v1/istio_types.go#L46-L49

@dgn
The type IstioUpdateStrategy has been set according to the following struct.
https://github.com/istio-ecosystem/sail-operator/blob/main/api/v1/istio_types.go#L72

Not completely sure about it.

hey @MaxBab that's the wrong type though, the correct type is https://github.com/kubernetes/api/blob/c31608c303d8330984b4a2db41cdba507107eda2/apps/v1/types.go#L582-L595

@dgn

Sorry, I'm confused.
Isn't the same type should appear for Istio and IstioCNI as well?
I don't see that type defined for them.

@dgn

Following our discussion on slack.
I've added the DaemonSetUpdateStrategy struct for the updateStrategy.

api/v1/values_types_extra.go

MaxBab · 2025-09-29T16:30:15Z

/test unit-tests

MaxBab · 2025-09-29T16:35:05Z

/retest

MaxBab · 2025-09-29T16:38:55Z

/test e2e-kind-olm

MaxBab · 2025-09-29T16:42:10Z

/test e2e-kind

MaxBab · 2025-09-29T17:11:56Z

/retest

MaxBab · 2025-09-29T19:31:38Z

/retest

* upstream/main: (41 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1325) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) fix: add v1.26.1 version (istio-ecosystem#1301) Make sure a correct helm values file is used (istio-ecosystem#1297) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1303) Small change in the migration from sidecar to ambient doc (istio-ecosystem#1300) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1296) ...

* upstream/main: (42 commits) Update sleep kustomization file (istio-ecosystem#1327) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1325) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) fix: add v1.26.1 version (istio-ecosystem#1301) Make sure a correct helm values file is used (istio-ecosystem#1297) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1303) Small change in the migration from sidecar to ambient doc (istio-ecosystem#1300) ...

* upstream/main: (43 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1332) Update sleep kustomization file (istio-ecosystem#1327) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1325) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) fix: add v1.26.1 version (istio-ecosystem#1301) Make sure a correct helm values file is used (istio-ecosystem#1297) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1303) ...

* upstream/main: (45 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1336) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1335) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1332) Update sleep kustomization file (istio-ecosystem#1327) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1325) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) fix: add v1.26.1 version (istio-ecosystem#1301) ...

* upstream/main: (46 commits) Increase timeouts in multicluster tests (istio-ecosystem#1337) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1336) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1335) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1332) Update sleep kustomization file (istio-ecosystem#1327) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1325) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1307) ...

* upstream/main: (47 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1341) Increase timeouts in multicluster tests (istio-ecosystem#1337) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1336) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1335) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1332) Update sleep kustomization file (istio-ecosystem#1327) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1325) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1324) Prevent pruning IstioRevisions with unknown InUse status (istio-ecosystem#1322) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1323) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1321) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1320) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1318) Increase e2e timeout when waiting for service LB (istio-ecosystem#1314) docs: IstioCNI: mention resource name restriction (istio-ecosystem#1288) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1313) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1311) Update Ztunnel config CRD flags (istio-ecosystem#1117) Fix ZTunnel name field in UI (istio-ecosystem#1284) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1308) ...

MaxBab requested a review from a team as a code owner August 13, 2025 09:11

istio-testing added the size/L label Aug 13, 2025

MaxBab requested review from dgn and sridhargaddam August 13, 2025 09:12

MaxBab force-pushed the update_ztunnel_config_crd_flags branch from 6f5516b to 0f94813 Compare August 13, 2025 09:18

dgn reviewed Sep 4, 2025

View reviewed changes

api/v1/values_types_extra.go Outdated Show resolved Hide resolved

dgn reviewed Sep 4, 2025

View reviewed changes

api/v1/values_types_extra.go Outdated Show resolved Hide resolved

MaxBab force-pushed the update_ztunnel_config_crd_flags branch from 0f94813 to 51de8a4 Compare September 7, 2025 09:03

MaxBab mentioned this pull request Sep 9, 2025

[FEATURE] Add global.network to Ztunnel CR #1210

Closed

1 task

MaxBab force-pushed the update_ztunnel_config_crd_flags branch from 51de8a4 to bc62906 Compare September 9, 2025 15:46

This comment was marked as resolved.

Sign in to view

MaxBab force-pushed the update_ztunnel_config_crd_flags branch from bc62906 to 23f445f Compare September 9, 2025 16:00

FilipB added the cherrypick/release-1.27 label Sep 11, 2025

MaxBab force-pushed the update_ztunnel_config_crd_flags branch from 23f445f to ee2512f Compare September 17, 2025 11:12

dgn reviewed Sep 24, 2025

View reviewed changes

MaxBab force-pushed the update_ztunnel_config_crd_flags branch from ee2512f to c9c1daf Compare September 29, 2025 16:24

MaxBab commented Sep 29, 2025

View reviewed changes

api/v1/values_types_extra.go Outdated Show resolved Hide resolved

istio-ecosystem deleted a comment from istio-testing Sep 29, 2025

Conversation

MaxBab commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Additional information:

Uh oh!

codecov bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MaxBab commented Aug 19, 2025

Uh oh!

MaxBab commented Aug 31, 2025

Uh oh!

Uh oh!

Uh oh!

MaxBab commented Sep 9, 2025

Uh oh!

This comment was marked as resolved.

FilipB commented Sep 11, 2025

Uh oh!

MaxBab commented Sep 11, 2025

Uh oh!

dgn Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

MaxBab Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

MaxBab Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgn Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

MaxBab Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

MaxBab Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MaxBab commented Sep 29, 2025

Uh oh!

MaxBab commented Sep 29, 2025

Uh oh!

MaxBab commented Sep 29, 2025

Uh oh!

MaxBab commented Sep 29, 2025

Uh oh!

MaxBab commented Sep 29, 2025

Uh oh!

MaxBab commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MaxBab commented Aug 13, 2025 •

edited

Loading

codecov bot commented Aug 13, 2025 •

edited

Loading

MaxBab Oct 16, 2025 •

edited

Loading