Skip to content

docs: ztunnel: mention resource name restriction#1266

Merged
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
zmiklank:ztunnel_crd_docs
Oct 14, 2025
Merged

docs: ztunnel: mention resource name restriction#1266
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
zmiklank:ztunnel_crd_docs

Conversation

@zmiklank
Copy link
Copy Markdown
Contributor

@zmiklank zmiklank commented Oct 13, 2025

  • [*] Documentation Update

What this PR does / why we need it:

The PR mention name enforcement in ZTunnel CRD docs.

@zmiklank
docs: ztunnel: mention resource name restriction
9924150 
Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
@zmiklank zmiklank requested a review from a team as a code owner October 13, 2025 18:38
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 13, 2025

Hi @zmiklank. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sridhargaddam
sridhargaddam reviewed Oct 13, 2025
View reviewed changes
@sridhargaddam
Copy link
Copy Markdown
Contributor

sridhargaddam commented Oct 13, 2025

/ok-to-test

@zmiklank @sridhargaddam
docs: ztunnel CRD: make clear why we allow only default name
88c01d4 
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
@zmiklank
Copy link
Copy Markdown
Contributor Author

zmiklank commented Oct 14, 2025

Thanks @sridhargaddam for review. I included your proposed change.

sridhargaddam
sridhargaddam approved these changes Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Zuzana.

@istio-testing istio-testing merged commit 84294eb into istio-ecosystem:main Oct 14, 2025
11 of 12 checks passed
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
@zmiklank @sridhargaddam @dgn
docs: ztunnel: mention resource name restriction (istio-ecosystem#1266)
095fa16 
* docs: ztunnel: mention resource name restriction

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>

* docs: ztunnel CRD: make clear why we allow only default name

Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>

---------

Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sridhargaddam sridhargaddam sridhargaddam approved these changes

Assignees

No one assigned

Labels

ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zmiklank @istio-testing @sridhargaddam