Infer the JWS signing algorithm name by looking at the provided key #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles cases where the JWS message or the key do not have a proper `alg` header. The `alg` header is optional[0], so some identity providers may not supply it (such as Microsoft Identity[1]) [0]: https://datatracker.ietf.org/doc/html/rfc7517#section-4.4 [1]: https://login.microsoftonline.com/common/discovery/v2.0/keys Signed-off-by: Erik Haugrud <[email protected]>
erik-h
force-pushed
the
optional-alg-key
branch
from
d1ccea6 to
b264d29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage ? 90.31%
=======================================
Files ? 24
Lines ? 1569
Branches ? 0
=======================================
Hits ? 1417
Misses ? 108
Partials ? 44
|
nacx
reviewed
Apr 13, 2024
erik-h
force-pushed
the
optional-alg-key
branch
from
f0a17b5 to
54013aa
Compare
Signed-off-by: Erik Haugrud <[email protected]>
Signed-off-by: Erik Haugrud <[email protected]>
erik-h
force-pushed
the
optional-alg-key
branch
from
54013aa to
a44ea63
Compare
Signed-off-by: Erik Haugrud <[email protected]>
erik-h
force-pushed
the
optional-alg-key
branch
from
75caf08 to
03ec224
Compare
|
@nacx thanks for the review! I've added a couple comments and fixed the linter issues. |
nacx
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erik-h, nacx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thx! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles cases where the JWS message or the key do not have a proper
algheader. Thealgheader is optional, so some identity providers may not supply it (such as Microsoft Identity).